Remove support for non-glimmer template-only components #20685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template-only-glimmer-components optional feature became mandatory at 4.0. This removes the implementation for the unreachable branch.
Merged
NullVoxPopuli
approved these changes
Apr 22, 2024
Contributor
|
I don't understand. I updated Ember to 5.10, removed Same for the |
Contributor
Author
|
Yeah it looks like that assertion needs to get cleaned up. You can leave the setting in place for now to silence it. If you want to make a PR taking it out it's here: Line 95 in 0da8387 |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template-only-glimmer-components optional feature became mandatory at 4.0. This removes the implementation for the unreachable branch.