feat: type modifier on imports #20101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
reviewed
May 27, 2022
snewcomer
force-pushed
the
sn/type-modifier-import
branch
from
61d0e67 to
5ee8c16
Compare
3 tasks
Member
|
Is this still relevant? It is a draft PR |
Contributor
|
I think it got implemented via #20593 and prior PRs. |
Member
|
Closing as completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - trying to get this syntax to compile....
Previously, as on Typescript 3.8, we had the ability to import types, albeit on a new line.
As of 4.5, we can inline that type, making it easier to manage top level imports.
fixer PR (in progress): typescript-eslint/typescript-eslint#5050. Once this is merged, I'll run it on the whole repo.
follow up: #20087
Docs: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names