Use `ebryn/backburner.js#cleanup-build` by seanpdoyle · Pull Request #10853 · emberjs/ember.js

seanpdoyle · 2015-04-08T23:25:10Z

Ignore me.

seanpdoyle · 2015-04-09T01:59:21Z

@rwjblue I'm seeing this failure locally:

Build failed.
File: htmlbars-syntax/handlebars/compiler/base.js
htmlbars-syntax/handlebars/compiler/base.js: Unexpected token (4:7)
SyntaxError: htmlbars-syntax/handlebars/compiler/base.js: Unexpected token (4:7)
  2 | import AST from "./ast";
  3 | import WhitespaceControl from "./whitespace-control";
> 4 | module Helpers from "./helpers";
    |        ^
  5 | import { extend } from "../utils";
  6 | 
  7 | export { parser };

which is fun, because I can't seem to track down the file in question. Could you point me in the right direction?

seanpdoyle · 2015-04-09T02:05:40Z

// node_modules/htmlbars/dist/cjs/htmlbars-syntax/handlebars/compiler/base.js
var Helpers = __es6_transpiler_build_module_object__("Helpers", require("./helpers"));

is the compiled output in question, but the source file doesn't exactly exist

seanpdoyle · 2015-04-09T02:08:22Z

https://github.com/wycats/handlebars.js/blob/37a664bf6438bde0ee827a68da4cbd95a21cf52e/lib/handlebars/compiler/base.js#L4

this is fun 🌀

seanpdoyle · 2015-04-09T02:16:07Z

attempted to correct in handlebars-lang/handlebars.js#993

seanpdoyle · 2015-04-21T20:22:09Z

@rwjblue seems like Travis' cache isn't busted by npm or bower:

https://travis-ci.org/emberjs/ember.js/jobs/59451384

rwjblue · 2015-04-21T20:26:34Z

I can clear the Travis cache, but Ember master cannot use [email protected] since it requires the latest updates to Handlebars (that only works in idempotent-rerender).

seanpdoyle · 2015-04-21T20:33:11Z

@rwjblue got it. should I roll emberjs-build back to 0.0.48 and keep going?

stefanpenner · 2015-04-21T21:39:32Z

@seanpdoyle let me know, if that branch (on backburner) is ready to be merged. I can pull the switch.

seanpdoyle · 2015-04-21T21:50:40Z

@stefanpenner which branch? (https://github.com/ebryn/backburner.js/pulls)

I think it's been merged.

stefanpenner · 2015-04-21T21:59:06Z

@seanpdoyle ah!

seanpdoyle · 2015-04-21T22:01:58Z

@stefanpenner @rwjblue could we clear the cache so that these new versions stick?

stefanpenner · 2015-04-21T22:31:53Z

@seanpdoyle i've blown the cache. I wonder if travis is interleaving caches per branch...

stefanpenner · 2015-04-21T22:35:50Z

purged again, rerunning.

seanpdoyle · 2015-04-21T22:45:45Z

@stefanpenner doesn't seem to have been purged: https://travis-ci.org/emberjs/ember.js/jobs/59469948#L137-L142

stefanpenner · 2015-04-21T23:06:37Z

@seanpdoyle i think travis is borked, i blew all of the caches away

seanpdoyle · 2015-04-22T00:47:24Z

@stefanpenner @rwjblue somehow we're back to this:

File: rsvp.umd.js
`this` at the top level is undefined
Error: `this` at the top level is undefined
    at Object.walk.enter (/home/travis/build/emberjs/ember.js/node_modules/emberjs-build/node_modules/esperanto/dist/esperanto.js:216:13)
    at visit (/home/travis/build/emberjs/ember.js/node_modules/emberjs-build/node_modules/esperanto/dist/esperanto.js:58:9)

https://travis-ci.org/emberjs/ember.js/jobs/59480207

seanpdoyle · 2015-04-22T01:01:42Z

Do I need these to be master in both bower and npm?

i believe this one is just for build tooling

seanpdoyle · 2015-04-22T01:26:24Z

seanpdoyle · 2015-04-22T01:44:20Z

@stefanpenner could you purge the cache again?

stefanpenner · 2015-04-22T11:09:26Z

@stefanpenner could you purge the cache again?

i think travis fixed their underlying issue, restarting tests.

stefanpenner · 2015-04-22T11:14:28Z

@stefanpenner @rwjblue somehow we're back to this:

These UMD files, are not for esperanto to consume. They exist as input files to the old es6-module-transpilers bundle format. We should just filter then out of the tree before passing to esperanto.

I suspect this will simplify things.

use fixed branch use esperanto branch use emberjs-build Use fixed `rsvp.js` and `dag-map` use `rsvp` and `dag-map` master use backburner master

seanpdoyle · 2015-06-07T21:30:42Z

@stefanpenner this is using master of backburner.

Should I peg it to a particular commit?

stefanpenner · 2015-06-07T22:54:36Z

Ah. I'll poke around

seanpdoyle mentioned this pull request Apr 8, 2015

Cleanup build BackburnerJS/backburner.js#129

Merged

3 tasks

seanpdoyle force-pushed the sd-backburner-branch branch 2 times, most recently from faa6285 to 5198006 Compare April 9, 2015 01:22

seanpdoyle mentioned this pull request Apr 9, 2015

Use import instead of module handlebars-lang/handlebars.js#993

Closed

seanpdoyle force-pushed the sd-backburner-branch branch 3 times, most recently from 9ad6589 to d3dc84d Compare April 21, 2015 01:33

seanpdoyle mentioned this pull request Apr 21, 2015

Use emberjs-build tildeio/htmlbars#331

Merged

seanpdoyle force-pushed the sd-backburner-branch branch from 6bc470c to 29a6926 Compare April 21, 2015 22:37

seanpdoyle force-pushed the sd-backburner-branch branch from 29a6926 to c9a4773 Compare April 22, 2015 00:33

seanpdoyle reviewed Apr 22, 2015
View reviewed changes

seanpdoyle force-pushed the sd-backburner-branch branch from 9db2b29 to 13c9f9a Compare April 23, 2015 02:23

seanpdoyle force-pushed the sd-backburner-branch branch from 13c9f9a to 4dad9bc Compare June 7, 2015 19:20

Use ebryn/backburner.js#cleanup-build

5f1aaf8

use fixed branch use esperanto branch use emberjs-build Use fixed `rsvp.js` and `dag-map` use `rsvp` and `dag-map` master use backburner master

seanpdoyle force-pushed the sd-backburner-branch branch from 4dad9bc to 5f1aaf8 Compare June 7, 2015 19:22

seanpdoyle mentioned this pull request Jun 7, 2015

Remove .js from .umd suffix BackburnerJS/backburner.js#138

Merged

seanpdoyle reviewed Jun 7, 2015
View reviewed changes

stefanpenner self-assigned this Jul 8, 2015

rwjblue closed this Aug 2, 2015

seanpdoyle deleted the sd-backburner-branch branch August 2, 2015 23:39

Uh oh!

Conversation

seanpdoyle commented Apr 8, 2015

Uh oh!

seanpdoyle commented Apr 9, 2015

Uh oh!

seanpdoyle commented Apr 9, 2015

Uh oh!

seanpdoyle commented Apr 9, 2015

Uh oh!

seanpdoyle commented Apr 9, 2015

Uh oh!

seanpdoyle commented Apr 21, 2015

Uh oh!

rwjblue commented Apr 21, 2015

Uh oh!

seanpdoyle commented Apr 21, 2015

Uh oh!

stefanpenner commented Apr 21, 2015

Uh oh!

seanpdoyle commented Apr 21, 2015

Uh oh!

stefanpenner commented Apr 21, 2015

Uh oh!

seanpdoyle commented Apr 21, 2015

Uh oh!

stefanpenner commented Apr 21, 2015

Uh oh!

stefanpenner commented Apr 21, 2015

Uh oh!

seanpdoyle commented Apr 21, 2015

Uh oh!

stefanpenner commented Apr 21, 2015

Uh oh!

seanpdoyle commented Apr 22, 2015

Uh oh!

seanpdoyle Apr 22, 2015

Choose a reason for hiding this comment

Uh oh!

stefanpenner Apr 22, 2015

Choose a reason for hiding this comment

Uh oh!

seanpdoyle commented Apr 22, 2015

Uh oh!

seanpdoyle commented Apr 22, 2015

Uh oh!

stefanpenner commented Apr 22, 2015

Uh oh!

stefanpenner commented Apr 22, 2015

Uh oh!

seanpdoyle Jun 7, 2015

Choose a reason for hiding this comment

Uh oh!

stefanpenner commented Jun 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants