Add basic implementation of new ember-qunit API. #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rwjblue
commented
Oct 17, 2017
rwjblue
commented
- Add basic implementation of new ember-qunit API proposed in Add new QUnit testing API. rfcs#232.
- Move legacy testing system into legacy-2-x subfolder.
- Update to [email protected].
added 6 commits
October 17, 2017 13:17
This is in prep for the work needed to support the new testing API's proposed in emberjs/rfcs#232.
added 2 commits
October 17, 2017 15:37
PR is submitted to fix the plugin, once merged and released we can drop this back down.
The new API relies on the the public API added for `Ember.getOwner` / `Ember.setOwner`.
Turbo87
approved these changes
Oct 17, 2017
| export { default as moduleFor } from './legacy-2-x/module-for'; | ||
| export { | ||
| default as moduleForComponent, | ||
| } from './legacy-2-x/module-for-component'; |
Member
There was a problem hiding this comment.
this looks like we might want the 100 chars/line here too
Member
Author
There was a problem hiding this comment.
Yep, done in a later commit.
| import Ember from 'ember'; | ||
| import QUnit from 'qunit'; | ||
| import { QUnitAdapter } from 'ember-qunit'; | ||
| import QUnitAdapter from './adapter'; |
| teardownContext, | ||
| setupRenderingContext, | ||
| teardownRenderingContext, | ||
| } from 'ember-test-helpers'; |
Member
Author
There was a problem hiding this comment.
Actually, no. The other one is an export { .... } from which does not bring the exported things into the current scope.
This was referenced Oct 17, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.