This repository was archived by the owner on Jun 13, 2019. It is now read-only.
Updated packages and ember-cli-deploy #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aureliosaraiva
changed the title
acorncom
reviewed
Sep 3, 2017
| accessKeyId=ACCESSKEYID | ||
| secretAccessKey=SECRETACCESSKEY | ||
| bucket=bucket | ||
| region=us-east-1 |
Member
There was a problem hiding this comment.
Is there a reason we're deleting this file?
Author
There was a problem hiding this comment.
I removed it, because it was written example, I thought it was rubbish. Only that.
I can reverse this if you prefer
Collaborator
There was a problem hiding this comment.
Please do :) .something.example files are meant to illustrate what a .something should contain, without having to commit secrets, and without having to rename files and such. This way you can .gitignore the .env file and never accidentally leak secrets to the git repository.
Merged
Collaborator
|
Thanks for contributing @aureliosaraiva. Rob submitted #58 with some more important changes, so I went with that one instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44