defaultType support, mv partials code to resolver #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Jun 10, 2017
| [ 'template:/my-app/components/my-input', 'my-app/src/ui/components/my-input/template' ], | ||
| [ 'component:/my-app/components/my-input/my-button', 'my-app/src/ui/components/my-input/my-button/component' ], | ||
| [ 'template:/my-app/components/my-input/my-button', 'my-app/src/ui/components/my-input/my-button/template' ], | ||
| [ 'template:/my-app/routes/-author', 'my-app/src/ui/partials/author' ], |
Member
There was a problem hiding this comment.
Seems like the other changes in this PR make partials still work, why remove the test?
Member
Author
There was a problem hiding this comment.
I added a comment about this in the source- I'd like to see this bulk test be simmered down into smaller focused tests with better descriptions of the intent. @iezer and I took the first steps toward some utilities to help keep those test terse.
| }, | ||
|
|
||
| /* | ||
| * templates may acutally be partial lookups, so consider them as possibly |
andyhot
reviewed
Jun 10, 2017
|
|
||
| resolve(lookupString) { | ||
| /* | ||
| * Ember paritals are looked up as templates. Here we replace the template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultTypeto the Ember resolver config.defaultTypeinRequireJSRegistryto optionally check for the non-typed path.Closes: #189
Replaces: #183
with @iezer :-)