Isaac/glimmer #183
Closed
Isaac/glimmer #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, a service can exist in my-app/src/services/auth, or My-app/src/services/auth/service Support locations
This was referenced Jun 9, 2017
Member
|
I think most/all of these concerns are handled elsewhere now 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mixonic This adds a couple of things to the ember-resolver to support Module Unification:
(first commit) Looks up certain types like services and utils in two possible places, for example, for
service:auth, checkmy-app/src/ui/services/authandmy-app/src/ui/services/auth/service(second commit) Add tests for local lookup. This verifies that local lookup works as implemented in the
@glimmer/resolver, provided that we (via ember) pass the correct value forreferrer. These tests make explicit what we expect so that we can implement the right thing in Ember. Ember should pass the absolute specifier for the template, adding/-componentsat the end if it is coming from a route template. For example:posts: referrer:template:/app/routes/post/-componentsmy-input: referrer:template:/app/components/my-input