[embassy-executor] Add two new trace hooks, improve docs#4033
Merged
Conversation
Member
|
I'd just say it's stable (or not say anything, it's implied it's stable). No need to worry about compat, next release is going to be breaking anyway because of #4020. |
Contributor
Author
|
@Dirbaio removed that section! |
lulf
approved these changes
Apr 1, 2025
Contributor
Author
|
@Dirbaio any objections to me hitting merge? |
Member
|
yolo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension of the
traceinterface that adds two new hooks:_embassy_trace_poll_start- used to mark the time AFTER executor polling starts, but BEFORE task polling starts. This is usable for measuring overhead of the scheduler algorithm itself._embassy_trace_task_end- used to mark the end of a task, at the time of dropping the contained future and freeing the associated space.I've also added quite a bit of docs.
EDIT: this is a breaking change, but fine because #4033 (comment)