Closed
Conversation
Posts that specify a list of categories in the front matter will be
grouped and linked to the corresponding category pages.
- Import and modify generate_categories.rb from recurser/jekyll-plugins.
It generates /categories/#{category}/index.html for each category.
These pages list all posts that have that category.
- Modify post-header.html to print a post's categories, if available.
- Add category_index.html, the layout used by the category pages.
- Add categories to example pages to demonstrate.
- Add an example post to demonstrate how to use it.
Owner
|
Hi Alex, Thanks for the pull request! The demo page is great. I also added a few comments on your code. Unfortunately, I can't merge your pull request because as you said, the demo doesn't work automatically with Github Pages, and I'd like to make sure Shiori works on GitHub Pages. However, I added a section on README mentioning your demo and this pull request. Could you take a look? Thanks for your work! |
Author
|
Thanks for the mention and the code review! I've made the changes for your suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I like using Shiori theme but wanted category pages, so I added this. What do you think? Here's a demo.
Pages will be generated for each category and list all posts with that
category. Posts that specify a list of categories in the front matter will
be linked to the corresponding category pages.
It generates /categories/#{category}/index.html for each category.
These pages list all posts that have that category.