Support preloading associations in embedded schemas from the parent schema #3890
Description
Current behavior
defmodule Child do
use Ecto.Schema
schema "children" do
end
end
defmodule Parent do
use Ecto.Schema
schema "parents" do
embeds_many(:details, Detail, primary_key: false, on_replace: :delete) do
belongs_to(:child, Child)
end
end
end
Parent
|> preload(details: :child)
|> Repo.all()** (ArgumentError) schema Parent does not have association :details
...
By #3368, Ecto.Repo.c:preload/3 works from the embedded schema, but not from the parent schema yet.
Activity
josevalim commentedon May 1, 2022
Good find. We should probably "allow" embeds in preload as long as they are loading an association inside.
josevalim commentedon May 1, 2022
A pull request to address this is welcome!
Sleepful commentedon Jul 27, 2022
Working on a pull request for this
Failing tests per elixir-ecto#3890;
Implements Enhancement elixir-ecto#3890
Failing tests per elixir-ecto#3890;
Implements Enhancement elixir-ecto#3890
wakeless commentedon Aug 9, 2022
Thanks for doing this @Sleepful so nice.
I've been working on this as well and hadn't seen you'd been working along on it. My approach is a little more naive but thought I'd link it here in case there's something useful. master...wakeless:ecto:allow-preloading-within-nested-schemas
greg-rychlewski commentedon Sep 11, 2022
Closed by #3967