This repository was archived by the owner on Oct 1, 2023. It is now read-only.
Redesign of the proxy approach#23
Closed
opensource21 wants to merge 13 commits intoelisarver:masterfrom
Closed
Conversation
want to create some waits after an action.
test without a real app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the following problem with fragments: If a page is reloaded, the field of a fragment get a Stale-Exception. This is different to fields directly on a page. So I think it's a good idea that the field are always searched from scratch (as long as they are not have the annotation
@CacheLookup).This is broken for list and for fragments. Specially together with ajax this can become a problem.
I looked into the code and find that ElementImpl can easily do the search. Now ElementImpl works as Proxy. This has the positive side-effect that not for each method-call a new Object is created. The generic proxy looks wrong for me.
So I decided to change the implementation. Know everything works like a charme and should be faster as before.