Repository navigation
fix(runs): deny an expired run's open approval - #2181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
 [Medium impact] The PR appears safe to merge. SummaryExpired runs now use
No actionable issues found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "fix(runs): deny an expired run's open ap..." · Reviewed by Greptile |
Contributor
Playwright screenshotsNo new feature frames; gallery is suite-vs-main drift. Open screenshot gallery · Dashboard · CI run Updated for commit |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A run waiting on an approval card that nobody answers is eventually expired. Its card's effect then stayed
intended, since expiry only dropped the turn checkpoint. Stopping a thread and cancelling runs already deny it (#2171).What changed
expireStuckRunnow callsclearEndedRunStateafter cancelling the run, as the stop and cancel paths do. That also covers the checkpoint and the waiting one-time answer, so its own checkpoint and secret deletes are removed.How tested
A new unit test expires a run with an unanswered approval card and checks its effect is denied. It fails without the change. The existing secret-delete assertion still passes, and so does the Postgres steering-replay suite, which expires runs. Typecheck passes and Biome is clean on the changed files; the unit suite passes except the backup script tests, which fail the same way on main on macOS.