Repository navigation
Hide archived and under-minimum groups from search - #2125
Merged
Merged
Conversation
Group search results could surface archived groups and groups that no longer have GROUP_MEMBER_MIN active bots, neither of which can be opened. Apply the same rule getGroup/getGroupTarget use, across the direct group query, the group-artifacts query and the raw SQL group-message query.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
 [Medium impact] The PR appears safe to merge; both previous findings are addressed. SummarySearch excludes archived groups and groups below
Reviews (2) · Last reviewed commit: "Apply group eligibility before search li..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Search could return archived groups and groups that fell below
GROUP_MEMBER_MINactive bot members. Neither can be opened from results, so they read as dead ends. Closes #2037.What changed
apps/api/src/search.tsnow filters group hits the same waygetGroup/getGroupTargetdecide a group is openable:archivedAt IS NULLand at least two members whose bots are not archived. Applied to all three group queries: direct group search, group artifacts, and the raw SQL group-message search.search.test.tsgains coverage for archived and under-minimum groups.How tested
pnpm vitest run apps/api/src/search.test.tspasses (8 tests). The member-count filter mirrors the resolver logic, verified againstgetGroupTarget.