Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… πŸš€ Feature Request: Background image size selection #6778

Closed
2 tasks done
XVII opened this issue Jan 17, 2019 · 167 comments
Closed
2 tasks done

βœ… πŸš€ Feature Request: Background image size selection #6778

XVII opened this issue Jan 17, 2019 · 167 comments
Labels
mod* [Temp.] For internal use only. request/enhancement Indicates an Enhancement Request for an existing feature. request/feature Indicates a Request for a non-existing New Feature. solved Indicates that an Issue has been Solved, or a Feature Request has been Released. status/merged Indicates when a Pull Request has been merged to a Release. type/performance Indicates when a topic is related to Performance. type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens.
Milestone

Comments

@XVII
Copy link

XVII commented Jan 17, 2019

Prerequisites

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.
Opening a new ticket for the reconsideration of #3722, as advised by Elementor support.

This feature will prevent clients (especially mobile or limited bandwidth connections) from having to download a 5mb background image, when a 50kb one would be more appropriate.

Describe the solution you'd like
Native, and responsive background image source selection based on size, dimensions.

Wordpress does this by standard for normal blog images -- Elementor backgrounds should be smart enough to do this also.

Other elementor widgets already do this, i.e. Posts widget lets you pick the size of the image to use as the featured image header.

Ideally, there would be:

  • The ability to select a specific image size, rather than having it just use the "full" version.
  • A responsive option that fills in srcset for responsive scaling (as WordPress standard does).
  • Not just a single in-place src replacement -- otherwise caching proxies would pick up and save a specific size.

Describe alternatives you've considered
Third-party optimisation tools, but there are compatibility issues with Elementor.

Additional context
Elementor already has several performance-conscious features, I'm unsure why this particular scenario hasn't been addressed yet.

Multiple background images that was released in recent versions of Elementor is only going to multiply this issue.

@black-eye
Copy link

+1
Oh yes. Pls add an option to select image size (of the same image) for different media queries. Now we can chose only a different image.

And also pls add an option to remove bg image completely (on specific media query) and leave only the color.

@bainternet bainternet added the request/feature Indicates a Request for a non-existing New Feature. label Jan 20, 2019
@olehkoh13
Copy link

+1

@theorib
Copy link

theorib commented Jan 21, 2019

+1 on this, so important!

@parfilov
Copy link

+1 I wrote about this in 2.4 beta release post.

@michael3371
Copy link

+1 this would be a game changer in mobile speed opt.

@thenathantt
Copy link

+1 not having this feature is delaying load time across the board for me.

@gabiudrescu
Copy link

+1

2 similar comments
@sermalefico
Copy link

+1

@Micemade
Copy link

+1

@glebpineparks
Copy link

+1

Isnt its quite a large demand on this now? will you eventually add this feature? :)
It's a pain to crop images manually...

Also, why did the privious feature request topic is set as Closed, while feature still not there... :(

@jazir555
Copy link

+1

Mobile is more important than Desktop honestly, 60% of traffic is now estimated to be from mobile devices in recent studies conducted.

@glebpineparks
Copy link

@KingYes @kobizz
Elementor team, please notice this feature request!! :)
πŸ‘

@MHitMaN
Copy link

MHitMaN commented Apr 16, 2019

+1

@wpsumo
Copy link

wpsumo commented Apr 23, 2019

And please allow option to print the inline css reference. I would like to take advantage from plugins and image CDN's be able to grab all images to optimize. For smart cropping, dynamic resize for all devices. I do not want to deliver desktop size to mobile.

Would be good as you guys say in the thread to also be able (for user that dont use the setup I do) to set image site for background images, and normal img tags based on tablet and mobile.

@sermalefico
Copy link

+1

@arielk arielk added the type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens. label Aug 21, 2019
@mjb2000
Copy link

mjb2000 commented Aug 22, 2019

+1 from me

I have been trying to find how to do this in Elementor for the past 30 minutes.. I figured it had to be there because so many other features are so well implemented, but this is certainly something big that is missing.

Particularly for me, I am choosing a Product Image in WooCommerce and then using the "dynamic" feature to display the image in a "Single Product" template page. The product image selected is the original file, so it would be great if I could choose a different image size from the predefined Wordpress image variations for each of the responsive layouts.

@benhohner
Copy link

Please, reopen this issue.
Huge client-uploaded backgrounds are killing my sites' load times.

@KingGrizzly
Copy link

+1

1 similar comment
@rathert
Copy link

rathert commented Sep 10, 2019

+1

@damienrave
Copy link

+1 Elementor is such a great tool, please make it Pagespeed-friendly

@musback
Copy link

musback commented Sep 10, 2019

+1, as mentioned before, this would reduce my page sizes with at least 200kb each.

@twhaas
Copy link

twhaas commented Sep 10, 2019

Unfortunately this has not been added in the latest update which included some improvements on the background functionality. This is such a simple and highly necessary function, please consider adding this!

@hao24real
Copy link

hao24real commented Sep 10, 2019

+1
I can't believe this feature is not already included, as a computer science grad, I went from coding my own theme to using elementor pro for its ease of use. The fact they have dynamic content, shortcode and all these advanced features but missing this basic functionality is beyond my understanding.
If you do decide to implement it, make sure we still get to manually select different images for background while adding the option for the background to load different size of the same srcset image dynamically based on screen size.

@black-eye
Copy link

@twhaas

Unfortunately this has not been added in the latest update which included some improvements on the background functionality. This is such a simple and highly necessary function, please consider adding this!

Exactly my thought - so I added the same suggestion to 2.7 beta thread 14 days ago. It was marked as offtopic. OK, thread was propably meant just for bug reports, but 7 new requests right after 2.7 release prove, that this feature is needed even more than before.

Please make us happy, small improvements like this are what makes the difference between good and awesome. πŸ˜‰

@ianlee
Copy link

ianlee commented Oct 22, 2019

+1

@thomasch-easting
Copy link

Come on @elementor, we've passed the point where this is just a nice feature to have, it's a basic necessity for a professional website. I want my clients to upload images of any size, which are then automatically resized. Having 4MB background images is killing pagespeeds and SEO. It's nice that you are introducing new fancy dividers and parallax scrolling effects, but please divert some the time spent on this stuff to fix this very simple but highly needed feature. (Also, is @elementor even reading this?)

@pictureandword
Copy link

This is getting silly. I currently have a layout with a five column section - each column with a different background image. Despite the fact that Wordpress is generating exactly the sizes I want, I still have to Photoshop each image individually or else it will try and load ~10mb of images. And then I have to ask the client to do the same when updating.

This is basic functionality and this request will soon be having it's 4th birthday. Get this in the backlog please.

@erfan-ilyas
Copy link

Well that's true. You can select a totally different background image for Responsive Break points.
But the issue everyone here is talking about Background image size selection not using Responsive break points.

@caspervoogt
Copy link

The breakpoints are fine. The problem is the background image doesn't use WordPress's image sizes. The Image widget does... this should too.

@rtpHarry
Copy link

rtpHarry commented Nov 9, 2022

And the super annoying thing is that because of the way that the code is structured, this "widget" is a kind of special-case and there is no way to override it in the code for any developers to implement it themselves as a plugin.

The only way possible would be to filter the output html and then inject a new image in, which could work, but would mean that the original image had already been loaded with the call, so you would be loading the image twice. I wasted a weekend digging through the code trying to take this into my own hands, but ultimately reached that conclusion.

I suspect they will never fix this, and it might be an option in the flexbox successor; or we will be starting a new thread when that comes out for the next 4 years.

@caspervoogt
Copy link

caspervoogt commented Nov 9, 2022

@rtpHarry well there is a way.. see #6778 (comment) . But it's only for the pro version. I refuse to use workarounds for this though; I feel pretty strongly that this should be built into Elementor itself; it's such an essential feature.

@jomarieminney
Copy link

I brought this issue up with the Elementor Support team earlier today and asked them to get the dev team to comment on the issue or discussion and let us know if it is at least on their radar... then @fabianenzensperger noticed the above commit earlier today. Is this... progress? Are we just being overly hopeful? πŸ™

@avivu
Copy link

avivu commented Nov 10, 2022

Hi @jomarieminney,

Yes, the development is in progress.
We are investigating the issue and working to provide the best solution.

We will keep updating here with the findings and progress.
Thank you!

@nicholaszein nicholaszein changed the title Background image size selection πŸš€ Feature Request: Background image size selection Nov 23, 2022
@nicholaszein nicholaszein added the request/enhancement Indicates an Enhancement Request for an existing feature. label Nov 23, 2022
@arielk arielk added this to the 3.10.0 milestone Nov 27, 2022
@nicholaszein
Copy link
Member

nicholaszein commented Dec 14, 2022

Hello all,

I just wanted to give you an update about our progress with this feature:

We wanted to release it in 3.10, but thought the implementation is not right yet, so we'll take more time to investigate and release it in the near future. We want to make it right! I hope you can understand. πŸ€“

Apologies for keeping you waiting. We know this is important for you! And we hope to give you an update soon. πŸ™

Kind regards

@nicholaszein nicholaszein removed this from the 3.10.0 milestone Jan 11, 2023
@arielk arielk added this to the 3.11.0 milestone Jan 19, 2023
@arielk arielk added the status/merged Indicates when a Pull Request has been merged to a Release. label Jan 19, 2023
@nicholaszein nicholaszein changed the title πŸš€ Feature Request: Background image size selection βœ”οΈ πŸš€ Feature Request: Background image size selection Feb 13, 2023
@nicholaszein nicholaszein added solved Indicates that an Issue has been Solved, or a Feature Request has been Released. and removed status/merged Indicates when a Pull Request has been merged to a Release. product/beta3.11 labels Feb 13, 2023
@nicholaszein
Copy link
Member

Hello everyone!

We have great news! πŸ™Œ

πŸ“’ We're happy to announce that this feature was released with Elementor v3.11! πŸ₯³

βœ”οΈ Please feel free to check it out and update your plugin to the new version!

Cheers πŸ₯‚

@elementor elementor locked and limited conversation to collaborators Feb 13, 2023
@nicholaszein nicholaszein added the status/merged Indicates when a Pull Request has been merged to a Release. label Feb 13, 2023
@nicholaszein nicholaszein added the mod* [Temp.] For internal use only. label May 24, 2023
@nicholaszein nicholaszein changed the title βœ”οΈ πŸš€ Feature Request: Background image size selection βœ… πŸš€ Feature Request: Background image size selection May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mod* [Temp.] For internal use only. request/enhancement Indicates an Enhancement Request for an existing feature. request/feature Indicates a Request for a non-existing New Feature. solved Indicates that an Issue has been Solved, or a Feature Request has been Released. status/merged Indicates when a Pull Request has been merged to a Release. type/performance Indicates when a topic is related to Performance. type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens.
Projects
None yet
Development

No branches or pull requests