Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

β›” πŸš€ Background image size is missing when using a dynamic tag #21359

Closed
5 tasks done
perks98 opened this issue Feb 15, 2023 · 40 comments
Closed
5 tasks done
Labels
component/dynamic-tag References Elementor Pro’s Dynamic Tags feature. control/group/background References the Background group settings control. controls References any Widget Settings Control in the Elementor Editor. mod/b* [Temp.] For internal use only. mod/r* [Temp.] For internal use only. mod* [Temp.] For internal use only. product/pro Indicates if the referenced component is part of the Elementor Pro plugin. request/enhancement Indicates an Enhancement Request for an existing feature. type/styles Indicates when a topic is related to the styles or design of a component.

Comments

@perks98
Copy link

perks98 commented Feb 15, 2023

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

When using a dynamic tag to pull in an image like the featured image there are no image size options, while without using any tags you get the option to adjust the size.

Screenshot 2023-02-15 202136

Screenshot 2023-02-15 202231

Also when you add an image to the background first to make the size options appear then decide to use a dynamic tag for an image the size option says there but is not used in final frontend image render.

See steps to reproduce section for more info.

Steps to reproduce

Using a dynamic tag right away doesn't present the image size option:

2023-02-15.20-09-52.mp4

Choosing an image first then dynamic tag doesn't respect the size chosen in preview or frontend (should be thumbnail size in example):

2023-02-15.20-10-49.mp4

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a Blank WordPress theme active (Hello theme).
  • I can reproduce this bug consistently following the steps above.

System Info

System Info
					
== Server Environment ==
	Operating System: Linux
	Software: Apache
	MySQL version: MariaDB Server v10.4.26
	PHP Version: 7.4.33
	PHP Memory Limit: 128M
	PHP Max Input Vars: 2500
	PHP Max Post Size: 200M
	GD Installed: Yes
	ZIP Installed: Yes
	Write Permissions: All right
	Elementor Library: Connected

== WordPress Environment ==
	Version: 6.1.1
	Site URL: [private]
	Home URL: [private]
	WP Multisite: No
	Max Upload Size: 200 MB
	Memory limit: 40M
	Max Memory limit: 512M
	Permalink Structure: /%postname%/
	Language: en-GB
	Timezone: Europe/London
	Admin Email: [private]
	Debug Mode: Inactive

== Theme ==
	Name: Astra Child
	Version: 1.0.0
	Author: Brainstorm Force
	Child Theme: Yes
	Parent Theme Name: Astra
	Parent Theme Version: 4.0.2
	Parent Theme Author: Brainstorm Force

== User ==
	Role: administrator
	WP Profile lang: en_GB
	User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

== Active Plugins ==
	Astra Pro
		Version: 4.0.1
		Author: Brainstorm Force

	Better Search Replace
		Version: 1.4.2
		Author: WP Engine

	CookieYes | GDPR Cookie Consent
		Version: 3.0.8
		Author: CookieYes

	Elementor
		Version: 3.11.1
		Author: Elementor.com

	Elementor Pro
		Version: 3.11.1
		Author: Elementor.com

	FluentSMTP
		Version: 2.2.4
		Author: FluentSMTP & WPManageNinja Team

	Rank Math SEO
		Version: 1.0.108
		Author: Rank Math

	Redirection
		Version: 5.3.9
		Author: John Godley

	WooCommerce
		Version: 7.4.0
		Author: Automattic

	WooCommerce Handepay
		Version: 1.2
		Author: Handepay

	WooCommerce PayPal Payments
		Version: 2.0.2
		Author: WooCommerce


== Must-Use Plugins ==
	StackCache
		Version: 
		Author: Stack CP


== Features ==
	Custom Fonts: 0
	Custom Icons: 0

== Integrations ==
	
	recaptcha_v3: Active
	woocommerce: Active


== Elementor Experiments ==
	Optimised DOM Output: Active by default
	Improved asset loading: Active by default
	Improved CSS Loading: Active by default
	Inline Font Icons: Inactive by default
	Accessibility improvements: Active by default
	Additional Custom Breakpoints: Active by default
	admin_menu_rearrangement: Inactive by default
	Flexbox Container: Inactive by default
	Upgrade Swiper Library: Inactive by default
	Default to New Theme Builder: Active by default
	Editor V2: Inactive by default
	Landing pages: Active by default
	Nested Elements: Inactive by default
	Lazy Load Background Images: Inactive by default
	Save as Default: Active by default
	Page Transitions: Active by default
	Notes: Active by default
	Loop: Active by default
	Form Submissions: Active by default
	Scroll Snap: Active by default
	Mega Menu: Inactive by default


== Log ==
	
Log: showing 20 of 372023-01-31 09:45:22 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.10.2',
  'to' => '3.10.3',
)]
2023-02-13 11:34:21 [info] elementor::elementor_updater Started 
2023-02-13 11:34:21 [info] Elementor/Upgrades - _on_each_version Start  
2023-02-13 11:34:21 [info] Elementor/Upgrades - _on_each_version Finished 
2023-02-13 11:34:21 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor',
  'from' => '3.10.2',
  'to' => '3.11.0',
)]
2023-02-13 11:34:26 [info] elementor-pro::elementor_pro_updater Started 
2023-02-13 11:34:26 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-02-13 11:34:26 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-02-13 11:34:26 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.10.3',
  'to' => '3.11.0',
)]
2023-02-15 19:53:38 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor',
  'from' => '3.11.0',
  'to' => '3.11.1',
)]
2023-02-15 19:53:39 [info] elementor::elementor_updater Started 
2023-02-15 19:53:39 [info] Elementor/Upgrades - _on_each_version Start  
2023-02-15 19:53:39 [info] Elementor/Upgrades - _on_each_version Finished 
2023-02-15 19:53:39 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor',
  'from' => '3.11.0',
  'to' => '3.11.1',
)]
2023-02-15 19:53:41 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor',
  'from' => '3.11.0',
  'to' => '3.11.1',
)]
2023-02-15 19:54:04 [info] Elementor data updater process has been queued. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.11.0',
  'to' => '3.11.1',
)]
2023-02-15 19:54:04 [info] elementor-pro::elementor_pro_updater Started 
2023-02-15 19:54:04 [info] Elementor Pro/Upgrades - _on_each_version Start  
2023-02-15 19:54:04 [info] Elementor Pro/Upgrades - _on_each_version Finished 
2023-02-15 19:54:04 [info] Elementor data updater process has been completed. [array (
  'plugin' => 'Elementor Pro',
  'from' => '3.11.0',
  'to' => '3.11.1',
)]

PHP: showing 3 of 3PHP: 2023-02-06 10:15:49 [notice X 22][/home/sites/21b/b/ba92b594de/public_html/wp-content/plugins/elementor/includes/conditions.php::90] Trying to access array offset on value of type null [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-02-13 09:58:52 [notice X 2][/home/sites/21b/b/ba92b594de/public_html/wp-content/plugins/elementor/core/common/modules/ajax/module.php::172] Undefined index: data [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-02-13 11:21:46 [notice X 1][/home/sites/21b/b/ba92b594de/public_html/wp-content/plugins/elementor-pro/modules/theme-builder/classes/conditions-manager.php::168] Undefined index: editor_post_id [array (
  'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]

JS: showing 2 of 2JS: 2023-02-06 10:49:30 [error X 2][[private]/wp-admin/load-scripts.php?c=0&loadchunk_0=underscore,jquery-core,jquery-migrate,backbone,jquery-ui-core,jquery-ui-mouse,wp-api-request,regenerator-runtime,wp-polyfill,wp-&loadchunk_1=hooks&ver=6.1.1:4:51824] Cannot read properties of undefined (reading 'replace') 
JS: 2023-02-13 11:20:51 [error X 1][[private]/wp-content/plugins/elementor/assets/js/editor.min.js?ver=3.11.0:3:1087291] Cannot read properties of null (reading 'getBoundingClientRect') 



== Elementor - Compatibility Tag ==
	
	Elementor Pro: Compatible

== Elementor Pro - Compatibility Tag ==
	
@perks98 perks98 added the status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. label Feb 15, 2023
@DavidGMiles
Copy link

Yup crazy ommission, this makes the new feature half baked

@nicholaszein nicholaszein added bug Indicates a bug with one or multiple components. type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens. component/dynamic-tag References Elementor Pro’s Dynamic Tags feature. control/group/background References the Background group settings control. and removed status/awaiting_triage Indicates when an Issue, Pull Request, or Discussion awaits to be triaged. labels Feb 16, 2023
@nicholaszein
Copy link
Member

Hi @perks98!

Thank you for submitting your issue! πŸ™

Please allow us some time to investigate it, and get back to you with our findings. 🧐

Best regards

@nicholaszein nicholaszein changed the title 🐞 Bug Report: 3.11 Dynamic Background Image Size Options Missing [🧐 Evaluating] 🐞 Bug Report: 3.11 Dynamic Background Image Size Options Missing Feb 16, 2023
@XVII
Copy link

XVII commented Mar 2, 2023

Yep, totally missed the mark on that one. They locked previous thread (#6778) which is a pain.
It took 5 years to even get this far 🀦

@DavidGMiles
Copy link

Total fail so far - half baked feature - no progress - this is everything that is wrong with Elementor

@DavidGMiles
Copy link

Is this being fixed or just left as is?

@perks98
Copy link
Author

perks98 commented Mar 7, 2023

Not fixed in the 3.12 beta and I don't think there are any pull requests to fix so... left as is for now.

@DavidGMiles
Copy link

Not fixed in the 3.12 beta and I don't think there are any pull requests to fix so... left as is for now.

So half develop a feature, release, make a big fanfare about it, have bugs pointed out, and ignore them!

@XVII
Copy link

XVII commented Mar 7, 2023

My request to Elementor support:

Kindly be advised that we are already aware of this and our developers are currently working to fix it.
You will be notified once it is fixed.
Currently, we do not have an exact ETA for when this issue will be solved, but once the bug is fixed, we will update the status in our Changelog Page.

Am I confident they've picked up the full scope of this bug? Nope.

@perks98
Copy link
Author

perks98 commented Mar 8, 2023

I don't use Elementor support anymore as most issues I raise their developers are aware of but never have an ETA on fixing ~ like #14743 & #18874 OR the excuse is that it has been an issue for so long that users have found ways around it and fixing it now will break that ~ like #20041. These days I try only to report stuff around beta season as they are more likely to action or if it is a big major issue. Unfortunately 3.11 is already out so I don't think they will action this any time soon unless we have 50 users demand for it. ~~ but I could be wrong

@DavidGMiles
Copy link

5 years for a solution which is incomplete - it kind of sums Elementor up - if it’s not new and shiny they lose interest and leave bugs to fester

@caspervoogt
Copy link

caspervoogt commented Apr 5, 2023

Crazy that image sizes are still not possible with dynamic background images. That makes them much less useful. Super frustrating. I can't think of a sensible workaround. I just want to use a post's featured image as a banner image.. without having it load the full-resolution version.

@DavidGMiles
Copy link

DavidGMiles commented Apr 5, 2023 via email

@caspervoogt
Copy link

They have been focusing on performance improvements... and this is a big one. If they really cared about performance, they'd fix this.

@nicholaszein nicholaszein added the mod* [Temp.] For internal use only. label Apr 18, 2023
@DavidGMiles
Copy link

Will this half-completed feature ever be finished - it is useless as it stands - the ability to select Background Image Size Options when using a Dynamic Image source is really important for performance

@VerdiH
Copy link

VerdiH commented Jul 20, 2023

Any news @nicholaszein just got some questions about it

@DavidGMiles
Copy link

Any news @nicholaszein just got some questions about it

Evidently not - another one into the black hole I guess

@nicholaszein
Copy link
Member

@DavidGMiles and @VerdiH please refer to Amitai's section on Elementor's Q3 Roadmap Event. It should clear out any doubt about how we are dealing with bug reports.

https://www.youtube.com/live/PHqbPU-h0NY?feature=share&t=1316

@DavidGMiles please, if you have any complaints towards the Elementor Company, use the following channel:

https://elementor.com/contact

This is not the place for this kind of comment.

Thank you very much.

@sixgunnar
Copy link

This feature is definitely needed. Was surpised to find that the image size selection was added for background images in 3.11 because I could not see this option. Mostly use background images loaded from post featured image..

@DavidGMiles
Copy link

When I recently asked Elementor Support about this I was told 'This is not classified as a bug by our support teams, this is intended functionality'

@danielvigh
Copy link

+1

@perks98
Copy link
Author

perks98 commented Oct 27, 2023

Hi @perks98!

Thank you for submitting your issue! πŸ™

Please allow us some time to investigate it, and get back to you with our findings. 🧐

Best regards

Hi @nicholaszein,
Have you or your team had a chance yet to 'investigate' this yet? πŸ€”

@perks98
Copy link
Author

perks98 commented Oct 30, 2023

#24146 <-- not sure if that potential code relates to this issue but if it is then it looks like this issue may not get fixed and just a message of "Image size settings don’t apply to Dynamic Images." instead which isn't really a solution.

@nicholaszein nicholaszein changed the title [🧐 Evaluating] 🐞 Bug Report: 3.11 Dynamic Background Image Size Options Missing 🐞 Bug Report: Dynamic Background Image Size Options Missing - [ED-9824] Dec 7, 2023
@nicholaszein nicholaszein changed the title 🐞 Bug Report: Dynamic Background Image Size Options Missing - [ED-9824] 🐞 Bug Report: Background image size is missing when using a dynamic tag - [ED-9824] Dec 7, 2023
@zanga7
Copy link

zanga7 commented Dec 11, 2023

Anything for this?

@alexplex
Copy link

I'm also awaiting a fix for this.

@brajno
Copy link

brajno commented Apr 8, 2024

This has a huge impact on performance.

@ncasedk
Copy link

ncasedk commented Apr 9, 2024

Damn. Still no fix. This is VERY problematic

@nicholaszein nicholaszein added the mod/b* [Temp.] For internal use only. label Jun 3, 2024
@miguel-cravidao
Copy link

This is totally unacceptable.

@zanga7
Copy link

zanga7 commented Jul 5, 2024

Anything? Any work arounds?

@miguel-cravidao
Copy link

I would also like to have an update on this. Still using full sized images in every dynamic element I do.

I tried as workaround to use images but I can't make images center/fit as well as background images. I define min-height for images and object fit to center center but i can't get images center/cover properly like in background images.

@v3ctordesign
Copy link

So it's been 624 days and still nothing...

@miguel-cravidao
Copy link

A very simple update that could boost performance and give design freedom. It's sad.

@caspervoogt
Copy link

This is really a problem. I am using (and loving) loop grids and setting background images using dynamic tags, but can't use an image size with that. I have to use a workaround consisting of absolutely positioned Image elements and a bunch of custom CSS.

In this video I show the issue, along with my workaround using Image element and some absolutely positioned elements. This is not an ideal workaround at all; it serves to illustrate why the background image option desperately needs an image size option.

@miguel-cravidao
Copy link

miguel-cravidao commented Nov 20, 2024

Yes @caspervoogt tks for sharing but I refuse to go that path to do something so simple, unless i need have a project that requires some high degree of performance. Right now, with image compression and CDN i can live with that but super frustrated of course.

@caspervoogt
Copy link

@miguel-cravidao I know, it is ridiculous isn't it. Granted, it didn't take me long to do (because I am so used to having to use this workaround by now) ... but it's silly and sad to have to jump through such hoops.

@nicholaszein nicholaszein changed the title 🐞 Bug Report: Background image size is missing when using a dynamic tag - [ED-9824] β›” πŸš€ Background image size is missing when using a dynamic tag Jan 29, 2025
@nicholaszein nicholaszein added request/enhancement Indicates an Enhancement Request for an existing feature. mod/r* [Temp.] For internal use only. and removed bug Indicates a bug with one or multiple components. labels Jan 29, 2025
@nicholaszein
Copy link
Member

Hey everyone!

An update to this issue:

Initially this functionality was not intended to be implemented, and images loaded via dynamic tags couldn't have the resolution set. We intended to update the controls to inform this limitation by adding a note below the Background Image selector indicating this was not possible:

"Dynamic background images aren’t supported by Image Resolution settings"

However, due to the demand, we added this to our roadmap as a new feature.

Unfortunately, after performing various tests we concluded implementing this feature could have a heavy impact on performance both inside the Editor, as well as on the frontend during the first rendering of the page, when the CSS is being generated. So we placed this feature on hold until we improved our infrastructure.

But we have great news! πŸ™Œ

Support for this feature will be considered for Elementor v4, after all dynamic capabilities are implemented, in a future phase!

For this reason, we are closing this issue, and merging it with the Feature Request #22750.

Please join the discussion there, and cast your vote as well!

Thank you all for your feedback! πŸ™

@nicholaszein nicholaszein closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
@elementor elementor locked and limited conversation to collaborators Jan 29, 2025
@nicholaszein nicholaszein marked this as a duplicate of #22055 Jan 29, 2025
@nicholaszein nicholaszein marked this as a duplicate of #29714 Jan 29, 2025
@nicholaszein nicholaszein added controls References any Widget Settings Control in the Elementor Editor. type/styles Indicates when a topic is related to the styles or design of a component. product/pro Indicates if the referenced component is part of the Elementor Pro plugin. and removed type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens. labels Jan 29, 2025
@nicholaszein nicholaszein marked this as a duplicate of #30054 Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component/dynamic-tag References Elementor Pro’s Dynamic Tags feature. control/group/background References the Background group settings control. controls References any Widget Settings Control in the Elementor Editor. mod/b* [Temp.] For internal use only. mod/r* [Temp.] For internal use only. mod* [Temp.] For internal use only. product/pro Indicates if the referenced component is part of the Elementor Pro plugin. request/enhancement Indicates an Enhancement Request for an existing feature. type/styles Indicates when a topic is related to the styles or design of a component.
Projects
None yet
Development

No branches or pull requests