Groth16 cache validation fix #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristotleee
changed the title
franklynot
reviewed
Jan 14, 2025
src/bridge/connectors/connector_c.rs
Outdated
| } | ||
|
|
||
| // to reuse lock scripts in validation | ||
| pub fn get_lock_scripts_copy(&self) -> Vec<ScriptBuf> { self.lock_scripts.clone() } |
There was a problem hiding this comment.
I suggest we make the lock_scripts field on the connector public, instead of introducing this fn. It'd be less code and we don't lose on readability. In most connectors all of their fields are public, so it would just be consistent (although not required).
src/bridge/connectors/connector_c.rs
Outdated
| operator_taproot_public_key: &XOnlyPublicKey, | ||
| commitment_public_keys: &BTreeMap<CommitmentMessageId, WinternitzPublicKey>, | ||
| lock_scripts_generator: LockScriptsGenerator, | ||
| lock_scripts_copy: Option<Vec<ScriptBuf>>, |
There was a problem hiding this comment.
I would suggest renaming all occurrences of lock_scripts_copy to lock_scripts_cache to better explain the purpose of this parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.