Handle flatpak+https scheme #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I use GLib.File.copy to download the FlatpakRef. This was the easiest way without adding new external dependencies. |
danirabbit
requested changes
Jul 29, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected, just one request to make sure we throw an error dialog or I can't remember if Sideload has an error view. Something that the user can see the error
Member
Author
|
In order to be able to display an error to a user in the |
danirabbit
approved these changes
Jul 31, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Hey nice. I didn't realize that so many of these other errors were silent as well. Thanks for fixing those! Seems like everything is working as expected. Good job!
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169