Conversation
|
@bobby285271 can you have a look at this? We seem to have nix packaging in-tree here and I've broken it 😅 This PR adds some systemd user units that along with some changes to gala (and probably some other components) will resolve #17 I think pantheon elementary OS 6.0 will still continue to use the |
|
https://github.com/bobby285271/session-settings/actions/runs/1250907248 This should be the minimal change to make CI pass, though I was not able to |
davidmhewitt
force-pushed
the
systemd-units
branch
from
6692fa0 to
dddd74b
Compare
|
@bobby285271 Thanks, I've made those changes. I've never done anything with nix packaging before, so if you and @davidak are happy, I'm happy. There's a relevant issue about this change in NixOS here: NixOS/nixpkgs#101817 |
|
I see no problem, but i'm also no expert with session management. |
|
That's OK, I'll handle testing the session management stuff, just wanted to check the nix packaging files still look good! |
JoseExposito
left a comment
JoseExposito
left a comment
There was a problem hiding this comment.
Not an expert, but from my limited experience on the topic, it looks good. I'd appreciate if someone else could look at it as well.
| # Start happens explicitly | ||
| RefuseManualStart=no | ||
| # Stop happens by starting gnome-session-shutdown.target | ||
| #RefuseManualStop=yes |
There was a problem hiding this comment.
Should we remove this comments before merging?
There was a problem hiding this comment.
These unit files are just direct copies of the ones from gnome-session, just tweaked where necessary to make it run pantheon instead and these lines come from there. It seems nicer to keep them as similar as possible to the gnome-session ones so we can see the diff if necessary.
|
I tested this on NixOS without issues. NixOS/nixpkgs#140429 (comment) We will merge it into our unstable release when this PR is merged. When do you plan to merge this PR? |
|
Just for information, we later found some issues with |
That sounds like the various GSD components aren't starting as dependencies, did you find the source of the issue? |
Just updated the downstream PR to include the workaround: NixOS/nixpkgs#140429 (comment), maybe we need something like Details |
5 participants
Adds the necessary unit files to be able to launch Pantheon via
gnome-session's systemd support.Merging this will have no effect on the current way of launching the session, just prepares us for removing the
--builtinflag on the session in the future.This can be tested in conjunction with elementary/gala#1256 and elementary/gala#1255 . If you remove the
--builtinflag from/usr/share/xsessions/pantheon.desktop,gnome-sessionwill launch Pantheon using the systemd units instead of the XDG autostarts.