Fix double login authentication #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I can test and merge it only maybe in a couple of days time FYI. |
Member
|
Oops, previous comment was supposed to be from me haha. |
danirabbit
previously requested changes
Nov 22, 2022
Co-authored-by: Danielle Foré <[email protected]>
vjr
approved these changes
Nov 25, 2022
Member
vjr
left a comment
vjr
left a comment
There was a problem hiding this comment.
Yep... LGTM! works well too. Will merge this into my branch and update my PR to clean it up a bit and mark it ready for review shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #624