Fix double login #624
Fix double login #624
Conversation
|
@elementary/desktop-developers Any suggestions for how to get greeter to restart itself or via restart lightdm? See the code block starting here: https://github.com/elementary/greeter/pull/624/files#diff-3d3c3150c12cf12f07b12828137c3dc9478f9a12c21ad40905aef57c8e12255aR519 When I try to trigger lightdm restart I get the error "this requires interactive permissions" so any pointers on how to resolve this? Initial setup uses the systemd I think this draft PR with its current approach might be an acceptable way to resolve the issue but if anyone has a better approach I can give that a shot too. Thanks! |
|
I tried (probably incorrectly) to use the |
Co-authored-by: Danielle Foré <[email protected]>
|
@meisenzahl the rules file wasn't working because jammy still has an older version 0.105 of polkit which doesn't support rules/javascript! Came across this while searching the web while troubleshooting the issue. |
meisenzahl
left a comment
meisenzahl
left a comment
There was a problem hiding this comment.
@vjr nice work! Works as intended.
I have some comments where I'm not sure what would be best practice at this place.
@davidmhewitt I would be very happy about another review from you, since you have clearly more knowledge of Polkit 😁
| ResultInactive=no | ||
| ResultAny=no |
There was a problem hiding this comment.
This file ensures that the feature works as desired. However, the two rules are even more open in https://github.com/elementary/initial-setup/blob/master/data/49-io.elementary.initial-setup.pkla. From my point of view, however, we should leave them restricted here.
| install_data( | ||
| 'io.elementary.greeter.pkla', | ||
| install_dir: join_paths(get_option('sharedstatedir'), 'polkit-1', 'localauthority', '10-vendor.d') | ||
| ) |
There was a problem hiding this comment.
In https://github.com/elementary/initial-setup/blob/master/data/meson.build the pkla file is prefixed with 49. I wonder if we should also prefix the pkla file of Greeter.
There was a problem hiding this comment.
I suggest keeping the existing RDNN format as mentioned in the "man pklocalauthority" notes and not prepending with that number. It is already installed into 10-vendor.d which is intended (as the name implies and noted in the manpages) for vendors. But we'll see comments from reviewers.
|
@tintou fixed this with a patch in Lightdm. So we don't need to restart this anymore :) |
Fixes elementary/triage#92