Take photo or video on secondary click #204
Conversation
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
This works as expected - just a couple of minor comments.
Running the base handler after emitting a signal (which is not in an Idle) looks risky but no adverse effect was noticed in practice
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Code and functionality lgtm. Leaving for UX input.
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Removing the window handle completely here means that the window can no longer be moved at all.
I'm also kind of -1 on trading the window handle for right click here. It seems like being able to move the window by dragging anywhere is more useful than taking a photo with a secondary click, which I'm not sure it makes sense to expect that a secondary click to preform an action
… clicking on camera view
|
@danrabbit I found a solution so you can take a photo or video on secondary click and we can use a |
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Works for me! just one small comment
Co-authored-by: Danielle Foré <[email protected]>
Closes #55
Does exactly what the title says.
Hdy.WindowHandlehad to be removed to prevent that a secondary click on the camera view opens the secondary window context menu.