Skip to content

Flatpak repair #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 16 commits into from
Feb 6, 2023
Merged

Flatpak repair #1983

danirabbit merged 16 commits into from
Feb 6, 2023

Conversation

@meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Feb 2, 2023 •
edited
Loading

@meisenzahl
Copy link
Member Author

meisenzahl commented Feb 3, 2023 •
edited
Loading

I was about to create patches for Flatpak and OSTree in https://github.com/elementary/os-patches. But apparently, the fixes are already included in the default Ubuntu packages:

@mwleeds do you have any other idea what could be the reason that Flatpak installation break for users?

For example in #1981

@meisenzahl
Copy link
Member Author

meisenzahl commented Feb 3, 2023 •
edited
Loading

The last commit adds a working prototype to fix Flatpak installations. It runs flatpak --system repair and flatpak --user repair in the background.

The functionality is implemented via an Action. We could add a button in case of an error during an installation or update that suggests the repair and triggers the action.

Peek.2023-02-03.12-37.mp4

@elementary/ux would this be a solution we want to work on further?

@meisenzahl meisenzahl requested a review from a team February 3, 2023 11:51
danirabbit
danirabbit reviewed Feb 5, 2023
View reviewed changes
@meisenzahl
Copy link
Member Author

meisenzahl commented Feb 6, 2023

Peek.2023-02-06.15-45.mp4

@meisenzahl meisenzahl marked this pull request as ready for review February 6, 2023 15:08
@meisenzahl meisenzahl requested a review from danirabbit February 6, 2023 15:08
@meisenzahl
Copy link
Member Author

meisenzahl commented Feb 6, 2023

@danirabbit after a fresh installation of elementaryos-7.0-stable.20230129rc.iso in VirtualBox, I also have the runtime error you see in the video. With the steps in the video I am able to fix the error using this branch.

@danirabbit danirabbit requested a review from a team February 6, 2023 19:48
danirabbit
danirabbit approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue in a clean virtual machine, so let's goo 🚀

@danirabbit danirabbit enabled auto-merge (squash) February 6, 2023 20:48
@danirabbit danirabbit merged commit 0b55f84 into master Feb 6, 2023
@danirabbit danirabbit deleted the flatpak-repair branch February 6, 2023 20:49
@meisenzahl meisenzahl mentioned this pull request Feb 7, 2023
Closed
@danirabbit danirabbit mentioned this pull request Feb 7, 2023
Closed
@meisenzahl meisenzahl mentioned this pull request Feb 8, 2023
Closed
@ryonakano ryonakano mentioned this pull request Feb 9, 2023
Merged
@lenemter lenemter mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flatpak update error with MESA package in eOS 7 Runtime Updates don't seem to update Update 7.1 fails updates are not installing

3 participants

@meisenzahl @danirabbit