Skip to content

Replace deprecated code #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 8 commits into from
Oct 21, 2020
Merged

Replace deprecated code #1418

danirabbit merged 8 commits into from
Oct 21, 2020

Conversation

@meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Sep 27, 2020 •
edited
Loading

  • ../src/Core/PackageKitBackend.vala:420.90-420.120: warning: `AppStream.ProvidedKind.MIMETYPE' is deprecated. Use MEDIATYPE
  • ../src/Dialogs/StripeDialog.vala:192.43-192.57: warning: `Gtk.Dialog.get_action_area' has been deprecated since 3.12
  • ../src/Views/AppListUpdateView.vala:323.17-323.38: warning: implicit .begin is deprecated
  • ../src/Dialogs/RestartDialog.vala:81.31-81.45: warning: `Gtk.Dialog.get_action_area' has been deprecated since 3.12

@meisenzahl
Copy link
Member Author

meisenzahl commented Sep 27, 2020 •
edited
Loading

  1. The action_area in RestartDialog gets only styled. Can we remove this code because Gtk.Dialog.get_action_area has been deprecated?
  2. The action_area in StripeDialog gets styled and a Gtk.LinkButton is added. Can we replace the logic with Gtk.Dialog.add_button?

@danirabbit
Copy link
Member

danirabbit commented Sep 29, 2020

I think we should be able to do something like:

        var privacy_policy_link = new Gtk.LinkButton.with_label ("https://stripe.com/privacy", _("Privacy Policy")) {
            halign = Gtk.Align.START,
            hexpand = true
        };

        add_action_widget (privacy_policy_link, Gtk.ResponseType.NONE);

But to avoid having to manually mess with margins in dialogs, we need elementary/stylesheet#839

@meisenzahl meisenzahl requested a review from danirabbit October 21, 2020 17:46
@danirabbit danirabbit merged commit e3a9b4f into elementary:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meisenzahl @danirabbit @cassidyjames