fix(components): [config-provider] preserve zero zIndex by guozi9999 · Pull Request #24331 · element-plus/element-plus

guozi9999 · 2026-05-26T09:58:28Z

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.

Summary

Preserve 0 as a valid global z-index value.
Add a regression test for ConfigProvider zIndex={0}.

Problem

useGlobalComponentSettings used || to fall back to defaultInitialZIndex:

computed(() => config.value?.zIndex || defaultInitialZIndex)

This caused 0 to be treated as missing because 0 is falsy.

Solution

Use ?? so only null or undefined fall back to the default:

computed(() => config.value?.zIndex ?? defaultInitialZIndex)

Summary by CodeRabbit

Bug Fixes
- ConfigProvider now correctly treats an explicit zIndex of 0 as valid and only falls back to the default initial z-index for missing or invalid numeric values (e.g., NaN), preventing accidental overrides from falsy values.
Tests
- Added tests verifying explicit zIndex=0 is preserved and that invalid/missing zIndex values fall back to the default.

github-actions · 2026-05-26T09:58:39Z

coderabbitai · 2026-05-26T09:58:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f43dbf9-d8ca-4a7b-9669-c3f52d91d0bf

📥 Commits

Reviewing files that changed from the base of the PR and between 1a4a65f and 9b57f8a.

📒 Files selected for processing (1)

packages/components/config-provider/src/hooks/use-global-config.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/components/config-provider/src/hooks/use-global-config.ts

📝 Walkthrough

Walkthrough

Compute logic for global component zIndex now treats 0 as a valid configured value and falls back to defaultInitialZIndex only when zIndex is null/undefined or NaN. Tests were added verifying that zIndex={0} is preserved and zIndex={Number.NaN} falls back to defaultInitialZIndex.

Changes

Z-Index handling fix and tests

Layer / File(s)	Summary
Explicit zIndex null/NaN check `packages/components/config-provider/src/hooks/use-global-config.ts`	Changed zIndex fallback from a `
Tests for zero and NaN zIndex `packages/components/config-provider/__tests__/config-provider.test.tsx`	Updated imports to include `defaultInitialZIndex` and added tests verifying `useGlobalComponentSettings('button')` yields `initialZIndex` of `0` when `ConfigProvider` sets `zIndex={0}`, and falls back to `defaultInitialZIndex` when `zIndex={Number.NaN}`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

A rabbit nibbles through the code, 🐰
Counting zeros, not a single one to goad,
It finds NaN and says "fallback, please,"
But lets 0 sit proudly as the zIndex breeze. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing the config-provider to preserve zero as a valid zIndex value.
Description check	✅ Passed	The description includes a clear summary with problem statement, solution, and references the linked issue `#24330`. It explains the root cause and the fix.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#24330` by replacing the \|\| operator with ?? (nullish coalescing) in useGlobalComponentSettings to preserve 0 as valid zIndex, and adds a regression test.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the zIndex=0 preservation issue: the hook logic change, test cases, and imports of isNil utility are all in scope.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-26T09:59:57Z

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus@24331

npm i https://pkg.pr.new/element-plus@24331

yarn add https://pkg.pr.new/[email protected]

commit: 9b57f8a

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1857622971

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-05-26T10:06:06Z

🧪 Playground Preview: https://element-plus.run/?pr=24331
Please comment the example via this playground if needed.

guozi9999 · 2026-05-29T04:31:00Z

I've made the requested changes. Please review when convenient. Thanks!

github-actions · 2026-05-29T11:41:24Z

@guozi9999 Thanks for your contribution! ❤️

fix(components): [time-select] guard invalid time values

1857622

pull-request-triage Bot assigned guozi9999 May 26, 2026

pull-request-triage Bot added the Needs Review label May 26, 2026

github-actions Bot added the Contribution::Community label May 26, 2026

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Comment thread packages/components/config-provider/src/hooks/use-global-config.ts Outdated

guozi9999 changed the title ~~fix(components): [time-select] guard invalid time values~~ fix(components): [config-provider] preserve zero zIndex May 26, 2026

fix(components): [config-provider] preserve zero zIndex

1a4a65f

rzzf reviewed May 29, 2026

View reviewed changes

Comment thread packages/components/config-provider/__tests__/config-provider.test.tsx

rzzf reviewed May 29, 2026

View reviewed changes

Comment thread packages/components/config-provider/src/hooks/use-global-config.ts Outdated

fix(components): replace original == null check with isNil

9b57f8a

rzzf approved these changes May 29, 2026

View reviewed changes

btea approved these changes May 29, 2026

View reviewed changes

btea merged commit 951afc1 into element-plus:dev May 29, 2026
17 checks passed

element-bot mentioned this pull request May 29, 2026

D2M #24346

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(components): [config-provider] preserve zero zIndex#24331

fix(components): [config-provider] preserve zero zIndex#24331
btea merged 3 commits into
element-plus:devfrom
guozi9999:fix/config-zindex-zero

guozi9999 commented May 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented May 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented May 26, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

guozi9999 commented May 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

guozi9999 commented May 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Summary by CodeRabbit

Uh oh!

github-actions Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guozi9999 commented May 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

guozi9999 commented May 26, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented May 26, 2026 •

edited

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading

pkg-pr-new Bot commented May 26, 2026 •

edited

Loading

github-actions Bot commented May 26, 2026 •

edited

Loading