fix(build): generate correct DTS for all non-entry files by rzzf · Pull Request #24179 · element-plus/element-plus

rzzf · 2026-04-30T03:44:33Z

resolves:

Based on https://github.com/sxzz/rolldown-plugin-dts#entry

Summary by CodeRabbit

Chores
- Updated build toolchain dependencies to newer pinned versions for more predictable, reproducible builds.
- Refined type-definition generation: tightened which source files are included and updated plugin configuration to improve consistency and clearer exclusions.

github-actions · 2026-04-30T03:44:42Z

coderabbitai · 2026-04-30T03:44:46Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Pin build tool dependencies and tighten DTS input selection: internal/build/package.json updates rolldown packages; internal/build/src/tasks/types-definitions.ts narrows glob inputs and supplies an explicit entry list plus cwd: pkgRoot to the rolldown-plugin-dts config.

Changes

Cohort / File(s)	Summary
Dependency Pinning `internal/build/package.json`	Bumped/changed rolldown deps from rc.6 / 0.22.2 → rc.12 / 0.23.2, affecting resolved build-tool versions.
Type Definitions Generation `internal/build/src/tasks/types-definitions.ts`	Replaced previous glob-derived `input` with narrowed `/index.ts` pattern; added `cwd: pkgRoot` and an explicit `entry` glob (`/*.{ts,tsx,vue}`) to `rolldown-plugin-dts`, excluding style files, tests/mocks, buildfiles, and certain subtrees—changing which sources are considered for DTS output.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: fix locale/lang/*.ts dts default export #23741: Alters DTS plugin/input glob handling for locale files and related entries.
fix(dts): some type declarations in tree-v2 are missing #24116: Adjusts which component files (e.g., virtual-tree) are included in DTS generation.

Suggested labels

CommitMessage::Unqualified

Poem

🐰 I hopped through globs both narrow and wide,

Pinned the rollers so versions won't slide,
I trimmed out tests and styles from the view,
Now type maps bundle tidy and true,
A little rabbit's cheer for the build pipeline.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description is minimal but includes essential information: related issue/PR links and a reference to the rolldown-plugin-dts documentation explaining the changes.	Add more detailed explanation of what the changes fix, why the glob pattern changes are necessary, and what the expected outcome is for users.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing DTS generation for non-entry files by updating build toolchain and glob patterns.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/dts-non-entry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-04-30T03:45:44Z

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus@24179

npm i https://pkg.pr.new/element-plus@24179

yarn add https://pkg.pr.new/[email protected]

commit: c538eaa

rzzf · 2026-04-30T03:45:50Z

@zhixiaotong 你可以试一下这个更改对你的项目有效吗？

github-actions · 2026-04-30T03:46:16Z

Size Change: +50.6 kB (+3.4%)

Total Size: 1.54 MB

📦 View Changed

Filename	Size	Change
`dist/element-plus/dist/index.full.js`	465 kB	+25.9 kB (+5.91%)	🔍
`dist/element-plus/dist/index.full.min.js`	289 kB	-335 B (-0.12%)
`dist/element-plus/dist/index.full.min.mjs`	282 kB	-319 B (-0.11%)
`dist/element-plus/dist/index.full.mjs`	455 kB	+25.4 kB (+5.91%)	🔍

ℹ️ View Unchanged

Filename	Size
`dist/element-plus/dist/index.css`	47.3 kB

_{compressed-size-action}

github-actions · 2026-04-30T03:50:59Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	86.28%	18677 / 21646
🔵	Statements	85.11%	19555 / 22974
🔵	Functions	84.64%	4957 / 5856
🔵	Branches	75.73%	10890 / 14379

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/components/carousel/src/use-carousel.ts	70.86%	56.52%	72.91%	70.8%	111-112, 118-122, 127-128, 133, 152-168, 174-200, 230, 265, 271, 277, 284, 302

Generated in workflow #2715 for commit c538eaa by the Vitest Coverage Report Action

github-actions · 2026-04-30T03:51:38Z

🧪 Playground Preview: https://element-plus.run/?pr=24179
Please comment the example via this playground if needed.

rzzf · 2026-04-30T05:55:47Z

The change in the full bundle size is caused by the upgrade of Rolldown

zhixiaotong · 2026-04-30T06:06:36Z

我看到了，我稍后试一下~

zhixiaotong · 2026-04-30T08:44:08Z

似乎不行，我用pnpm下载，可能是本地已经有2.13.7的版本，导致无法查看变化，于是用npm在另一个地方下载了，这个没看到里面有dts文件

rzzf · 2026-04-30T08:46:41Z

@zhixiaotong 有删除node_modules之后重新安装吗？

zhixiaotong · 2026-04-30T08:57:55Z

npm不会受pnpm缓存影响，但我打开npm下载的构建物，没有dts呢

rzzf · 2026-05-08T02:51:05Z

Now, rolldown 1.0
was released. After upgrading the dependencies, builds with full input entries are no longer excessively slow.

rzzf · 2026-05-08T03:09:27Z

Based on the CI results, the build time after the upgrade does not differ much from the previous run. I'm not sure what exactly caused this, but on my machine, the build was almost impossible to complete before the upgrade. I once waited for more than 20 minutes and it still didn't finish, whereas now the result is similar to CI and completes in around 10-20 seconds.

latest build: https://github.com/element-plus/element-plus/actions/runs/25533838024/job/74945456753?pr=24179

last build: https://github.com/element-plus/element-plus/actions/runs/25250519279/job/74041782704?pr=24179

local build

pull-request-triage Bot assigned rzzf Apr 30, 2026

This comment was marked as resolved.

Sign in to view

This comment was marked as spam.

Sign in to view

rzzf marked this pull request as draft April 30, 2026 04:45

rzzf force-pushed the fix/dts-non-entry branch from 374a9fd to be516d6 Compare April 30, 2026 05:49

rzzf marked this pull request as ready for review April 30, 2026 05:51

rzzf mentioned this pull request Apr 30, 2026

fix(build): add missing DTS for internal files #24178

Closed

3 tasks

Uh oh!

Conversation

rzzf commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

pkg-pr-new Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzzf commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as spam.

rzzf commented Apr 30, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

zhixiaotong commented Apr 30, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

zhixiaotong commented Apr 30, 2026

Uh oh!

rzzf commented Apr 30, 2026

Uh oh!

zhixiaotong commented Apr 30, 2026

Uh oh!

rzzf commented May 8, 2026

Uh oh!

This comment was marked as resolved.

rzzf commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzzf commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

rzzf commented May 8, 2026 •

edited

Loading