packages/components/dialog/__tests__/dialog.test.tsx (1)

322-348: Add an edge-case test for explicit zIndex preservation.

This test validates reordering, but it doesn’t cover the contract that user-provided z-index must not be overridden (e.g. zIndex={0}). Adding that case would harden this PR’s objective.

Suggested additional test (example)

+    test('should not override explicit z-index when clicking penetrable dialog', async () => {
+      const wrapper = mount(
+        <Dialog modelValue={true} modal={false} modalPenetrable={true} zIndex={0}>
+          fixed z-index dialog
+        </Dialog>
+      )
+      await nextTick()
+      await rAF()
+      await nextTick()
+
+      const dialog = wrapper.find('.el-dialog')
+      const overlay = wrapper.find('.el-modal-dialog')
+      const before = Number((overlay.element as HTMLElement).style.zIndex)
+
+      await dialog.trigger('mousedown')
+      await nextTick()
+
+      const after = Number((overlay.element as HTMLElement).style.zIndex)
+      expect(after).toBe(before)
+    })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/components/dialog/__tests__/dialog.test.tsx` around lines 322 - 348,
Add a test that ensures a user-specified zIndex on a Dialog is preserved when
dialogs are re-ordered: mount two Dialogs (like in the existing test) but pass
an explicit zIndex (e.g., zIndex={0} or style with zIndex) to one of them, wait
for nextTick/rAF, capture the overlay/dialog zIndex via the existing getZIndex
helper, trigger('mousedown') on the other dialog to reorder, await nextTick, and
assert that the explicitly set dialog's zIndex has not been overridden (remains
equal to the original value) while still allowing the stacking order logic to
update other dialogs; reuse functions/methods from the test such as Dialog,
mount, nextTick, rAF, trigger('mousedown'), and getZIndex to locate where to add
this assertion.