Skip to content

fix(components): [tree] requireNodeKey arg in updateKeyChildren#23676

Merged
btea merged 1 commit into
element-plus:devfrom
E66Crisp:fix-tree
Feb 22, 2026
Merged

fix(components): [tree] requireNodeKey arg in updateKeyChildren#23676
btea merged 1 commit into
element-plus:devfrom
E66Crisp:fix-tree

Conversation

@E66Crisp
Copy link
Copy Markdown
Contributor

@E66Crisp E66Crisp commented Feb 22, 2026 •
edited by coderabbitai Bot
Loading

Please make sure these boxes are checked before submitting your PR, thank you!
correct requireNodeKey param for updateKeyChildren

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected validation message text in tree component to provide more accurate error feedback.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2026 •
edited
Loading

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 22, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A validation error message label in the updateKeyChildren method was corrected from 'updateKeyChild' to 'updateKeyChildren' to match the actual method name. No functional changes or API modifications were made.

Changes

Cohort / File(s) Summary
Validation Message Correction
packages/components/tree/src/tree.vue		 Updated internal validation message label in updateKeyChildren method from 'updateKeyChild' to 'updateKeyChildren' for consistency with method naming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A label was wrong, just a whisper away,
From 'Child' it should say 'Children' today,
In the tree where validation runs deep,
The fix was so small, yet matters we keep! 🌳✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: correcting the requireNodeKey parameter for the updateKeyChildren method in the tree component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes the required checklist template with all items checked, and provides a clear title about fixing the requireNodeKey parameter for updateKeyChildren.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2026 •
edited
Loading

Hello, @E66Crisp, your PR title does not meet the standards, please refer to here.
你好，@E66Crisp，你的 PR 标题不符合规范，请参考这里。

@github-actions github-actions Bot added the CommitMessage::Unqualified Unqualified commit message label Feb 22, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 22, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@23676

npm i https://pkg.pr.new/element-plus/element-plus@23676

yarn add https://pkg.pr.new/element-plus/[email protected]

commit: 99340bb

@E66Crisp E66Crisp changed the title fix(components): [tree] correct requireNodeKey param for updateKeyChildren fix(components): [tree] requireNodeKey arg in updateKeyChildren Feb 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2026

🧪 Playground Preview: https://element-plus.run/?pr=23676
Please comment the example via this playground if needed.

@btea btea merged commit b5d66fc into element-plus:dev Feb 22, 2026
24 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2026

@E66Crisp Thanks for your contribution! ❤️

@element-bot element-bot mentioned this pull request Feb 28, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@rzzf rzzf rzzf approved these changes

Assignees

@E66Crisp E66Crisp

Labels

CommitMessage::Unqualified Unqualified commit message Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@E66Crisp @btea @rzzf