refactor(components): [statistic] use type-based definitions by snowbitx · Pull Request #23452 · element-plus/element-plus

snowbitx · 2026-01-18T17:01:06Z

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.

ref #23399

Summary by CodeRabbit

Refactor
- Clarified public typings for the Statistic component and introduced a new public props alias (old alias deprecated).
- Switched the component to typed prop declarations with explicit default values for decimal/group separators, precision, value, and value style to standardize behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

github-actions · 2026-01-18T17:01:14Z

coderabbitai · 2026-01-18T17:01:17Z

📝 Walkthrough

Walkthrough

Replaces the runtime-exported prop type with an explicit exported TypeScript interface StatisticProps, adds a deprecated StatisticPropsPublic alias using ExtractPublicPropTypes, removes the ExtractPropTypes export/import, and updates the .vue component to use defineProps<StatisticProps>() with withDefaults.

Changes

Cohort / File(s)	Summary
Statistic type definitions `packages/components/statistic/src/statistic.ts`	Added exported `interface StatisticProps`; added `type StatisticPropsPublic = ExtractPublicPropTypes<typeof statisticProps>` (deprecated); removed exported `type StatisticProps = ExtractPropTypes<typeof statisticProps>` and removed `ExtractPropTypes` import; kept `statisticProps` with a deprecation notice.
Statistic component implementation `packages/components/statistic/src/statistic.vue`	Switched from `import { statisticProps }` to `import type { StatisticProps }`; changed `defineProps(statisticProps)` → `withDefaults(defineProps<StatisticProps>(), { decimalSeparator: '.', groupSeparator: ',', precision: 0, value: 0, valueStyle: undefined })`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

refactor(components): [check-tag] use type-based definitions #23424 — Same code-level refactor pattern: add exported Props interface, replace ExtractPropTypes with ExtractPublicPropTypes alias, and switch .vue to defineProps<T>() + withDefaults.
refactor(components): [col] use type-based definitions #23438 — Component migration from runtime prop object to explicit interface + typed defineProps with defaults.
refactor(components): [steps] use type-based definitions #23433 — Similar replacement of ExtractPropTypes-based exports with explicit interfaces and typed defineProps.

Suggested reviewers

keeplearning66

Poem

🐇 I hopped through props and set them right,
New interfaces tucked in tight,
Defaults snug in a tidy row,
Types now guide the props' flow,
A rabbit's nibble — code aglow ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: converting the statistic component to use type-based prop definitions instead of runtime-based ones.
Description check	✅ Passed	The description follows the template by checking all required checklist items and includes a reference to the related issue (`#23399`).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-01-18T17:46:58Z

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@23452

npm i https://pkg.pr.new/element-plus/element-plus@23452

yarn add https://pkg.pr.new/element-plus/[email protected]

commit: 09ee3f4

github-actions · 2026-01-18T17:53:07Z

🧪 Playground Preview: https://element-plus.run/?pr=23452
Please comment the example via this playground if needed.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/components/statistic/src/statistic.ts`:
- Around line 21-23: Change the formatter property return type in the
StatisticProps interface from void to string | number so consumers can return
displayable values; locate the formatter declaration (formatter?: (...args:
any[]) => void) in StatisticProps and update its signature to (value: number) =>
string | number (or a compatible generic signature like (...args: any[]) =>
string | number) to match the implementation in statistic.vue where the
formatter result is returned for display.

github-actions · 2026-01-19T13:23:35Z

@snowbitx Thanks for your contribution! ❤️

refactor(components): [statistic] use type-based definitions

c610576

pull-request-triage Bot assigned snowbitx Jan 18, 2026

pull-request-triage Bot added the Needs Review label Jan 18, 2026

github-actions Bot added the Contribution::Community label Jan 18, 2026

snowbitx and others added 2 commits January 19, 2026 01:45

fix: type error

ea79f30

Merge branch 'dev' into refactor/use-type-statistic

55bd739

btea mentioned this pull request Jan 19, 2026

Refactor Component Props to type-based declarations #23399

Closed

64 tasks

btea reviewed Jan 19, 2026

View reviewed changes

Comment thread packages/components/statistic/src/statistic.ts Outdated

snowbitx and others added 2 commits January 19, 2026 17:39

chore: correct function type

df511dd

Merge branch 'dev' into refactor/use-type-statistic

4c4fbd2

coderabbitai Bot reviewed Jan 19, 2026

View reviewed changes

Comment thread packages/components/statistic/src/statistic.ts Outdated

fix: update

09ee3f4

btea approved these changes Jan 19, 2026

View reviewed changes

rzzf approved these changes Jan 19, 2026

View reviewed changes

rzzf merged commit 41fee2c into element-plus:dev Jan 19, 2026
17 checks passed

element-bot mentioned this pull request Jan 30, 2026

D2M #23568

Merged

3 tasks

coderabbitai Bot mentioned this pull request Apr 27, 2026

feat(components): style properties support Boolean values #24165

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(components): [statistic] use type-based definitions#23452

refactor(components): [statistic] use type-based definitions#23452
rzzf merged 6 commits into
element-plus:devfrom
snowbitx:refactor/use-type-statistic

snowbitx commented Jan 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 18, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

snowbitx commented Jan 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

snowbitx commented Jan 18, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Jan 18, 2026 •

edited

Loading

coderabbitai Bot commented Jan 18, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 18, 2026 •

edited

Loading

github-actions Bot commented Jan 18, 2026 •

edited

Loading