refactor(components): [collapse] use type-based definitions#23443
Merged
Conversation
Contributor
|
|
Contributor
📝 WalkthroughWalkthroughThis PR refactors the Collapse and CollapseItem components to use explicit type-based prop interfaces instead of ExtractPropTypes. New TypeScript interfaces (CollapseProps, CollapseItemProps) are introduced with JSDoc documentation, ExtractPropTypes is replaced with ExtractPublicPropTypes, and component .vue files are updated to use typed defineProps with default values via withDefaults. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/components/collapse/src/collapse-item.vue`:
- Around line 57-60: The props declaration for CollapseItem (const props =
withDefaults(defineProps<CollapseItemProps>(), ...)) is missing an explicit
default for the disabled prop, causing it to be undefined instead of false;
update the withDefaults call for defineProps<CollapseItemProps>() (the same
place where title and icon defaults are set) to include disabled: false so
:aria-disabled="disabled" renders consistently.
In `@packages/components/collapse/src/collapse.vue`:
- Around line 16-19: The CollapseProps' boolean prop accordion currently has no
explicit default and will be undefined when omitted; update the props defaults
in the withDefaults call (the same place where modelValue and expandIconPosition
are set) to include accordion: false so props.accordion is always a boolean;
locate the const props = withDefaults(defineProps<CollapseProps>(), ...) block
in collapse.vue and add the accordion default entry to that defaults object.
Contributor
|
🧪 Playground Preview: https://element-plus.run/?pr=23443 |
64 tasks
rzzf
approved these changes
Jan 18, 2026
Contributor
|
@snowbitx Thanks for your contribution! ❤️ |
btea
reviewed
Jan 18, 2026
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.ref #23399
Summary by CodeRabbit
Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.