refactor(components): [row] use type-based definitions by lw56777 · Pull Request #23437 · element-plus/element-plus

lw56777 · 2026-01-18T07:54:40Z

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.

修复：#23399

Summary by CodeRabbit

New Features
- Row component now has default prop values: tag = 'div', gutter = 0, justify = 'start'.
Refactor
- Prop typings for the Row component reorganized into a clearer, public-facing interface for improved type safety and maintainability.
Deprecated
- Legacy public prop type alias marked deprecated in favor of the new RowProps interface.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-18T07:54:54Z

📝 Walkthrough

Walkthrough

Row component props were converted from a runtime prop object to an explicit exported TypeScript RowProps interface; a deprecated public alias was added. The SFC now uses defineProps<RowProps>() with withDefaults to declare default values.

Changes

Cohort / File(s)	Summary
Row prop interface definition `packages/components/row/src/row.ts`	Added exported `RowProps` interface (`tag`, `gutter`, `justify`, `align`) and inline docs; removed unused `ExtractPropTypes` import; added deprecated public alias / deprecation comments referencing the old `rowProps`-based type.
Row component props usage `packages/components/row/src/row.vue`	Replaced `defineProps(rowProps)` with `defineProps<RowProps>()`; added `withDefaults` setting `tag = 'div'`, `gutter = 0`, `justify = 'start'`; swapped `rowProps` import for `import type { RowProps } from './row'`.

Sequence Diagram(s)

(omitted — changes are type-refactor and defaulting updates with no new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

refactor(components): [input-number] use type-based definitions #23404: Same refactor pattern — replacing runtime prop objects with explicit TS prop interfaces and switching to defineProps<Type>() + withDefaults.
refactor(components): [link] use type-based definitions #23411: Same migration to exported Props interfaces and deprecation of prior prop-object-based types.
refactor(components): [switch] use type-based definitions #23420: Similar change introducing Props interface, deprecating ExtractPropTypes alias, and updating SFCs to defineProps<Type>() with defaults.

Suggested reviewers

btea

Poem

🐰 I hopped through props with nimble paws,
Typed each field, removed old laws,
Defaults snug, a tidy row —
Quiet code where breezes blow. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: refactoring the row component to use type-based prop definitions instead of object-based definitions.
Description check	✅ Passed	The PR description follows the template with all required checklist items marked complete, references issue `#23399`, and confirms adherence to contribution guidelines and branch targeting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-01-18T07:57:06Z

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@23437

npm i https://pkg.pr.new/element-plus/element-plus@23437

yarn add https://pkg.pr.new/element-plus/[email protected]

commit: fe6776d

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/components/row/src/row.ts`:
- Around line 36-38: The deprecation JSDoc on rowProps is misleading because
RowProps is a TypeScript type and doesn’t replace runtime validators/defaults;
update the comment on rowProps in row.ts to either remove the “Use `RowProps`
instead” suggestion or clarify that RowProps is type-only and does not supply
runtime validation/defaults, e.g., state that runtime consumers should continue
to use rowProps for validators/defaults while RowProps is the compile-time type,
and ensure the symbols mentioned are `rowProps` (runtime) and `RowProps` (type).

github-actions · 2026-01-18T07:59:51Z

github-actions · 2026-01-18T08:03:48Z

🧪 Playground Preview: https://element-plus.run/?pr=23437
Please comment the example via this playground if needed.

github-actions · 2026-01-18T08:49:58Z

@lw56777 Thanks for your contribution! ❤️

refactor(components): [row] use type-based definitions

055485f

pull-request-triage Bot assigned lw56777 Jan 18, 2026

pull-request-triage Bot added the Needs Review label Jan 18, 2026

github-actions Bot added the Contribution::Community label Jan 18, 2026

Merge branch 'dev' into refactor/row-ComponentProps-#23399

90c3bf3

rzzf mentioned this pull request Jan 18, 2026

Refactor Component Props to type-based declarations #23399

Closed

64 tasks

coderabbitai Bot reviewed Jan 18, 2026

View reviewed changes

Comment thread packages/components/row/src/row.ts

lw56777 added 2 commits January 18, 2026 16:12

fix: coderabbitai

2370866

Merge branch 'dev' into refactor/row-ComponentProps-#23399

4045d95

rzzf approved these changes Jan 18, 2026

View reviewed changes

rzzf requested changes Jan 18, 2026

View reviewed changes

Comment thread packages/components/row/src/row.ts

Update packages/components/row/src/row.ts

fe6776d

rzzf approved these changes Jan 18, 2026

View reviewed changes

btea approved these changes Jan 18, 2026

View reviewed changes

btea merged commit 931d309 into element-plus:dev Jan 18, 2026
16 of 17 checks passed

lw56777 deleted the refactor/row-ComponentProps-#23399 branch January 18, 2026 08:50

element-bot mentioned this pull request Jan 30, 2026

D2M #23568

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(components): [row] use type-based definitions#23437

refactor(components): [row] use type-based definitions#23437
btea merged 5 commits into
element-plus:devfrom
lw56777:refactor/row-ComponentProps-#23399

lw56777 commented Jan 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 18, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lw56777 commented Jan 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lw56777 commented Jan 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 18, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 18, 2026 •

edited

Loading

github-actions Bot commented Jan 18, 2026 •

edited

Loading

github-actions Bot commented Jan 18, 2026 •

edited

Loading