packages/components/select/__tests__/select.test.ts (1)

4243-4292: Suggest additional test coverage for edge cases.

The test successfully verifies that the empty slot is shown when a remote search returns no results. Consider adding the following test cases to ensure comprehensive coverage:

1. Negative test: Verify that without an empty slot, the dropdown hides when remote search returns empty results (to confirm the fix only applies when the slot is present).

2. Debouncing interaction: Test the initial focus behavior when debouncing is active and previousQuery is empty, to validate the edge case identified in the implementation review.

3. Loading state: Verify that the empty slot is shown correctly when loading transitions from true to false with no results.

4. Non-remote mode: Ensure that the empty slot behavior is unaffected in non-remote mode (existing functionality preserved).

🔎 Example test for negative case (no empty slot)

test('should hide dropdown when remote search returns empty without empty slot', async () => {
  const wrapper = mount({
    components: {
      'el-select': Select,
      'el-option': Option,
    },
    template: `
      <el-select
        v-model="value"
        filterable
        remote
        :remote-method="remoteMethod"
      >
        <el-option
          v-for="item in options"
          :key="item.value"
          :label="item.label"
          :value="item.value"
        />
      </el-select>
    `,
    setup() {
      const value = ref('')
      const options = ref<any[]>([])
      const remoteMethod = (query) => {
        options.value = [] // Always return empty
      }
      return { value, options, remoteMethod }
    },
  })
  const select = wrapper.findComponent(Select)
  const input = wrapper.find('input')
  await input.trigger('click')
  await input.setValue('query')
  await nextTick()
  await nextTick()
  // Without empty slot, dropdown should hide when no options
  expect((select.vm as any).dropdownMenuVisible).toBe(false)
})

Configuration used: defaults

Review profile: CHILL

Plan: Pro

packages/components/select-v2/src/useSelect.ts (1)

393-406: LGTM: Logic correctly implements empty slot visibility in remote mode.

The added condition (props.remote && !!slots.empty) appropriately keeps the dropdown open when a custom empty slot is provided during remote searches with no results. This prevents the dropdown from closing and hiding the empty-state content.

Optional: Add clarifying comment

Consider adding a brief inline comment to explain the remote + empty slot condition for future maintainability:

 const dropdownMenuVisible = computed({
   get() {
     return (
       expanded.value &&
       (props.loading ||
         !isRemoteSearchEmpty.value ||
+        // Keep dropdown open in remote mode to show custom empty slot content
         (props.remote && !!slots.empty)) &&
       (!debouncing.value || !isEmpty(states.previousQuery))
     )
   },

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Learnt from: btea
Repo: element-plus/element-plus PR: 23222
File: packages/components/timeline/__tests__/timeline.test.tsx:172-181
Timestamp: 2025-12-26T15:08:21.704Z
Learning: In Timeline component tests (`packages/components/timeline/__tests__/timeline.test.tsx`), when testing non-TimelineItem content in the default slot using functional component syntax with `mount(() => <TimeLine>...</TimeLine>)`, the test framework strips wrapper elements and `wrapper.element.innerHTML` contains only the text content, not the wrapper div HTML.