Skip to content

feat(components): [message-box] add confirmButtonType and cancelButtonType props#23193

Merged
Dsaquel merged 4 commits into
element-plus:devfrom
keeplearning66:feat/message-box-button-type
Dec 25, 2025
Merged

feat(components): [message-box] add confirmButtonType and cancelButtonType props#23193
Dsaquel merged 4 commits into
element-plus:devfrom
keeplearning66:feat/message-box-button-type

Conversation

@keeplearning66
Copy link
Copy Markdown
Member

@keeplearning66 keeplearning66 commented Dec 23, 2025 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

relate #23178
I found that Popconfirm has confirm-button-type and cancel-button-type props. Maybe we can add them to MessageBox as well.

demo

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 23, 2025 •
edited
Loading

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 23, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@23193

npm i https://pkg.pr.new/element-plus/element-plus@23193

yarn add https://pkg.pr.new/element-plus/[email protected]

commit: 08a4f89

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 23, 2025 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=23193
Please comment the example via this playground if needed.

rzzf
rzzf approved these changes Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rzzf rzzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Dsaquel Dsaquel merged commit 038174c into element-plus:dev Dec 25, 2025
15 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 25, 2025

@keeplearning66 Thanks for your contribution! ❤️

@keeplearning66 keeplearning66 deleted the feat/message-box-button-type branch December 26, 2025 01:15
@element-bot element-bot mentioned this pull request Jan 9, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@rzzf rzzf rzzf approved these changes

@Dsaquel Dsaquel Dsaquel approved these changes

Assignees

@keeplearning66 keeplearning66

Labels

Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keeplearning66 @btea @rzzf @Dsaquel