fix(components): [input] input width change by clearable (#7287)#10534
Closed
MrWeilian wants to merge 3 commits into
Closed
fix(components): [input] input width change by clearable (#7287)#10534MrWeilian wants to merge 3 commits into
MrWeilian wants to merge 3 commits into
Conversation
|
👋 @MrWeilian, seems like this is your first time contribution to element-plus.
|
pull-request-triage
Bot
added
1st contribution
Contributor
|
|
Contributor
|
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
Bot
added
Contribution::Community
CommitMessage::Qualified
Contributor
|
🧪 Playground Preview: https://element-plus.run/?pr=10534 |
Contributor
Author
MrWeilian
force-pushed
the
fix/input-width
branch
from
2d2b98a to
8408865
Compare
Member
|
@tolking Check it |
Member
|
为 clearable 图标增加一个占位符在现在看起来也是个不错的主意。 目前这个PR点击占位符的地方无法聚焦，合并最新代码后支持点击 suffix 聚焦 input。配合使用应该挺合理的 |
Contributor
Author
|
额强哥，还有一个小点就是我这个pr把关闭的icon移到了suffix前面，是不是会有一点小bc？
这样改是因为不提上去放到最前的话，可能会出现 icon/suffix 之间留了个空白的间距（close icon隐藏的时候）。
如果按照这样ok的话，晚点我解决下冲突和加多个点击聚焦的功能。 |
Member
|
移动图标的位置确实算一个BC 合并了最新代码就支持点击聚焦了 |
…s#7287) fix(components): [input] input width change by clearable (element-plus#7287) fix(components): [input] input width change by clearable (element-plus#7287) fix(components): [input] input width change by clearable (element-plus#7287)
MrWeilian
force-pushed
the
fix/input-width
branch
from
8408865 to
e6d0277
Compare
tolking
reviewed
Jun 28, 2023
Co-authored-by: qiang <[email protected]>
Contributor
Author
|
@tolking 强哥，这个 pr 有机会合吗 |
Member
|
Thank you for your contribution. This issue has been fixed in #23661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: [Bug Report] [Component] [input] clearable 会动态改变宽度