Repository navigation
Fix portdb missing un_partial_stated_room_stream_sequence setup - #20302
Merged
anoadragon453 merged 4 commits intoOct 7, 2026
Merged
anoadragon453 merged 4 commits into
anoadragon453 merged 4 commits into
Conversation
|
|
anoadragon453
approved these changes
Oct 7, 2026
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20277.
synapse_port_db.pyStep 2 set upun_partial_stated_event_stream_sequencebut neverun_partial_stated_room_stream_sequence, even though room.py reads that sequence for theun_partial_stated_room_stream. After a sqlite to postgres port,MultiWriterIdGeneratorcompares the sequencelast_valueagainstMAX(stream_id)instream_positions(sequence.py) and fails with the sequence inconsistent error from the issue.This adds the missing
_setup_sequencecall next to the event-stream one, same (table, column) tuple pattern.py_compileclean on the edited script. Could not run theportdbscript end to end here (needs live sqlite and postgres), so this is code-verified only.