Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Crash after updating to v1.11.94 on Windows #2161

Closed

Description

@meichthys

Steps to reproduce

  1. Click the Update button in the UI
  2. See Element crash
  3. Try to re-launch Element (Fails)

I don't see any errors logged to Windows Event Viewer

Outcome

Windows 11
Element Version: v1.11.94

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes

Activity

  1. added
    O-FrequentAffects or can be seen by most users regularly or impacts most users' first experience
    S-CriticalPrevents work, causes data loss and/or has no workaround
    on Feb 27, 2025
  2. jacotec commented on Feb 27, 2025

    @jacotec

    Same here, it kills Desktop apps which never can be restarted.
    Have filed an issue in Element-Web 5 minutes ago : element-hq/element-web#29379

    That version should be pulled immediately.

  3. arueckbeil commented on Feb 27, 2025

    @arueckbeil

    Can confirm, the app no longer starts after the update, crashed immediately. I'm on Windows 11 24H2 (26100.3323)

  4. FSG-Cat commented on Feb 27, 2025

    @FSG-Cat

    latest nightly on Windows 10 is also broken.

  5. AnarcoPunkRJ commented on Feb 27, 2025

    @AnarcoPunkRJ

    Same, I cant open.

    What should I do to be able to open it without losing my settings? Install the old version on top?

  6. linuxmail commented on Feb 27, 2025

    @linuxmail

    Hi,

    same for all Windows users at office.

  7. pinned this issue on Feb 27, 2025
  8. jacotec commented on Feb 27, 2025

    @jacotec

    Same, I cant open.

    What should I do to be able to open it without losing my settings? Install the old version on top?

    Download the app again: https://element.io/download
    All settings, rooms and (if there) the own config.json is still there. The download fortunately is 1.11.93.

    But then refuse to say "update" when the popup occurs ;-)

  9. linuxmail commented on Feb 27, 2025

    @linuxmail
  10. AnarcoPunkRJ commented on Feb 27, 2025

    @AnarcoPunkRJ

    Same, I cant open.
    What should I do to be able to open it without losing my settings? Install the old version on top?

    Download the app again: https://element.io/download All settings, rooms and (if there) the own config.json is still there. The download fortunately is 1.11.93.

    But then refuse to say "update" when the popup occurs ;-)

    Worked, thanks ^^

  11. 33 remaining items

  12. t3chguy commented on Feb 28, 2025

    @t3chguy
    Member

    When will this be patched?

    We pulled the .94 update. There is no need to patch given broken installs won't self fix as Node is crashing before our code gets to run the auto updater.

    https://element.io/blog/element-desktop-update-for-windows/

  13. sascha-wi commented on Feb 28, 2025

    @sascha-wi

    What a tremendous blunder...way to go.

  14. Rudolfo1967 commented on Feb 28, 2025

    @Rudolfo1967
  15. cli-ish commented on Feb 28, 2025

    @cli-ish

    When will this be patched?

    We pulled the .94 update. There is no need to patch given broken installs won't self fix as Node is crashing before our code gets to run the auto updater.

    https://element.io/blog/element-desktop-update-for-windows/

    It worked, thanks for the quick fix i am now on the version 1.11.93 like the
    https://packages.element.io/desktop/update/win32/x64/ lists.

  16. t3chguy commented on Feb 28, 2025

    @t3chguy
    Member

    Ultimately this bug was a horrible combination of things happening all at once.

    1. Our tests run on changes, not during releases
    2. Node shipped a new NAPI version in a minor release 22.14.0
    3. Our node version got changed out from under us leading to using 22.14.0 due to a Github runner-images update which we have no way of opting out of
    4. prebuild-install fails to determine target on Node 23.6.0 prebuild/prebuild-install#203
    5. Failures on Node.js 22 nodejs/node-addon-api#1639
    6. https://github.com/atom/node-keytar being archived and thus not receiving the fixes for the 2 above issues + element-desktop needs to move away from Keytar now it is deprecated #1947
    7. The Node crash being such that it isn't caught by a try-catch block Node hard crash when importing napi module nodejs/node#57233 meaning it took out the whole app and any capacity for it to recover or even log anything
    8. It wasn't caught by Nightlies because the Node update rollout was slow and only affected the nightly built just a handful of hours earlier - on which no one reported any issues.

    We have made some remediations:

    1. Pulled .94 installer & update nupkg
    2. Announcement and a blog post detailing how to recover (reinstall .93 - no data loss)
    3. Pinned the Node version to one which works 22.13.1
    4. Switched from keytar to keytar-forked - maintained by a github staffer (and unpinned node)

    Hoping to get #1947 on the agenda such that we can get away from unmaintained code but just ditching keytar would result in all existing sessions being thrown away, as it secures your session on disk at rest.

    We also have a backburner project coined Saner Releases which aims to flip how we do releases, including running smoke tests on the release artifacts before publishing them to catch exactly this sort of stuff.

    We do not have a QA team. The Web team is small (4 engineers most of the time and we often get pulled away to help other teams). Running manual tests on every update would be impossible given the vast amount of hardware and time one would need, automating it is difficult as many things lack test orchestration, like there's no test harness around Apple Keychain where we can mock things out to test keytar. So we do rely on users reporting from Nightlies in a wide range of environments to catch issues such as this.

  17. MichaMican commented on Mar 3, 2025

    @MichaMican

    @t3chguy You might also want to pull this version from the GitHub Releases

    Image

  18. bblacher commented on Mar 3, 2025

    @bblacher

    @MichaMican The GitHub releases don't include binaries, as this is a bug in the build system the GitHub releases don't need to be pulled.

  19. t3chguy commented on Mar 3, 2025

    @t3chguy
    Member

    Yeah, only the windows version was pulled. Mac and Linux are still on 94

  20. t3chguy commented on Mar 3, 2025

    @t3chguy
    Member

    Unfortunately seems like Node doesn't care that a try-catch is useless to catch broken dependencies if the N-API is involved. We have done all that we can remediate against this issue.

    Closing in favour of

    element-hq/element-web#32278 which would give us more control by moving away from Node to something which lets us trap & recover from issues of this sort.
    #1947 which moves away from archived code.
    The saner releases project which adds release artifact testing as much as possible.

    The next Element Desktop release will go out on schedule.

  21. unpinned this issue on May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions