Fix slowlog crash when redirection fails#129
Merged
doyoubi merged 5 commits intoeleme:masterfrom Sep 11, 2017
Merged
Conversation
6f8c6b4 to
5e1ad16
Compare
tevino
approved these changes
Sep 5, 2017
Contributor
tevino
left a comment
There was a problem hiding this comment.
LGTM
A test case would be great.
05cfcf1 to
6c2bd6f
Compare
6c2bd6f to
115da6c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corvus may crash when it fails to connect to redis and try to create a sub-slowlog for multiple key command.
The Buggy Code
How To Reproduce
(1) Use the following Python 3 script to mock a redis cluster and let corvus connect to it.
Note that the
slowlog-log-slower-thanshould be 0 andslowlog-max-lenshould be positive.(2) Send a
MGET SomeKeyto corvus and trigger a crash.