Merged
Conversation
doyoubi
force-pushed
the
feature/ConfigRewrite
branch
2 times, most recently
from
5a5ab99 to
9a85d4a
Compare
doyoubi
force-pushed
the
feature/ConfigRewrite
branch
from
9a85d4a to
f00791e
Compare
doyoubi
force-pushed
the
feature/ConfigRewrite
branch
from
f00791e to
5d9e2df
Compare
doyoubi
force-pushed
the
feature/ConfigRewrite
branch
from
9559b5a to
6d12f07
Compare
doyoubi
commented
Mar 6, 2017
|
|
||
| bool config_option_changable(const char *option) | ||
| { | ||
| const char *CHANGABLE_OPTIONS[] = {"node", "loglevel", "slowlog-log-slower-than"}; |
Contributor
Author
There was a problem hiding this comment.
We should put it in the doc.
| } | ||
|
|
||
| // Caller should free the returned vector. | ||
| // Return an empty line array if fail to open or read old config file. |
Contributor
Author
There was a problem hiding this comment.
Typo here: read old config file => read empty config file
doyoubi
commented
Mar 6, 2017
| if (EOF == fputs(buf.data, fp)) { | ||
| goto end; | ||
| } | ||
| // Note that dict_set will save the key in its inner space |
Contributor
Author
There was a problem hiding this comment.
save the key pointer in its inner space
| void *WRITTEN_TAG = (void*)1; | ||
| struct dict written_tags, options_map; | ||
| dict_init(&written_tags); | ||
| dict_init(&options_map); |
Contributor
Author
There was a problem hiding this comment.
dict_set will not overwrite the same key. It just add the key again with another value.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #95 I explained why we need
config set node:The first problem has been solved by #95, so we continue to address the second one by adding a new command
config rewrite.