Merged
Conversation
wooparadog
approved these changes
Nov 14, 2016
doyoubi
reviewed
Nov 14, 2016
Contributor
doyoubi
left a comment
doyoubi
left a comment
There was a problem hiding this comment.
Please fix the little typo, others LGTM
src/corvus.c
Outdated
| int ch; | ||
| opterr = optind = 0; | ||
| do { | ||
| ch = getopt_long(argc, (char * const *)argv, ":n:t:c:b:l:r:R:s:B:C:S:A:m:L:P:g:G:E:", opts, NULL); |
Contributor
There was a problem hiding this comment.
I think you don't need 'r' and 'R' here. They are not used.
Contributor
Author
There was a problem hiding this comment.
what the hell a good shooting
i changed the args plan several times and forgot to sync the shorts compared to long options.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
att