Generate async methods with synthetic access modifier#31
Merged
JoeHegarty merged 1 commit intoelectronicarts:masterfrom Dec 5, 2018
Merged
Generate async methods with synthetic access modifier#31JoeHegarty merged 1 commit intoelectronicarts:masterfrom
JoeHegarty merged 1 commit intoelectronicarts:masterfrom
Conversation
ea-async generated bytecode can create problems with tools that analyze the java bytecode directly without looking at the source code. Usually these tools ignore bytecode methods that are marked as synthetic since that means it is compiler generated code not written directly by a user. This change ensures that all methods generated are marked as synthetic, which fixes issues with aforementioned tools.
Member
|
Awesome, thanks. I should be able to get this in a release later this week. |
Contributor
Author
|
@JoeHegarty would it be possible to do a release today? |
Member
|
Release is cut. Should be in Maven Central shortly. |
Contributor
Author
|
Awesome. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ea-async generated bytecode can create problems with tools that analyze
the java bytecode directly without looking at the source code. Usually
these tools ignore bytecode methods that are marked as synthetic since
that means it is compiler generated code not written directly by a user.
This change ensures that all methods generated are marked as synthetic,
which fixes issues with aforementioned tools.