docs: define practices for third-party extensible APIs#586
Merged
samuelmaddock merged 5 commits intoelectron:mainfrom Oct 10, 2024
Merged
docs: define practices for third-party extensible APIs#586samuelmaddock merged 5 commits intoelectron:mainfrom
samuelmaddock merged 5 commits intoelectron:mainfrom
Conversation
Co-authored-by: Will Anderson <[email protected]>
Co-authored-by: Will Anderson <[email protected]>
69f98bf to
2ac1df9
Compare
5 tasks
itsananderson
approved these changes
Oct 10, 2024
|
Thanks for your work on this! |
23 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of Electron's existing APIs don't do a good job of supporting extensibility for third-party libraries. Let's try to define best practices to guide future API designs with third-party extensibility in mind.
protocol.registerSchemesAsPrivilegedregisterSchemesAsPrivilegedcannot be used by libraries electron#40362session.setPreloads/session.getPreloads