On Windows I have a couple of dozens size/position related tests fail with all numbers being off by one or two pixels. Error messages are like this:

window.open
   ✕ does not override child options
    Assertion error: 'size: 352 451' == 'size: 350 450'
    ...

On Mac it doesn't happen, so I guess it has something to do with native window code.
Can someone please take a look?

On Windows I have a couple of dozens size/position related tests fail with all numbers being off by one or two pixels.

What DPI are you using locally?

What DPI are you using locally?

I was able to reproduce the failure at 150% zoom, but it passes for me at 100% zoom.

I was able to reproduce the failure at 150% zoom, but it passes for me at 100% zoom.

Zoom was set to 125%, with 100% those tests passed. Thanks.

Seems failing tests related to Windows system zoom level are already reported in #9691
As there're some other issues concerning zoom level, could we have tests for zoom level > 100% on Windows ci runner? Not for this chromium upgrade but someday after.

@alexeykuzmin I fixed the OSR-related errors on macOS.

From the looks of it, there should be no Windows specific errors, but if there are, let me know and we might be able to solve it, then we can enable OSR in update.py.

@gerhardberger Cool, thanks! Let's enable OSR and see what happens.

there should be no Windows specific errors, but if there are, let me know and we might be able to solve it

@gerhardberger compilation on Windows failed, check this out:
http://208.52.191.140:8080/job/electron-win-x64/3515/console

I guess it's related to https://codereview.chromium.org/2773433003

@gerhardberger I'm pretty you've already seen it, but Windows build failed again.
http://208.52.191.140:8080/job/electron-win-x64/3516/console

@alexeykuzmin yeah I saw it. I managed to resolve the errors all but one, because that is a different sort of issue.

Tomorrow I will take a closer look at it!

A single test failed in a Mac build:

not ok 775 <webview> tag permission-request event emits when using navigator.getUserMedia api
  AssertionError: [ 'DevicesNotFoundError' ] deepEqual [ 'PermissionDeniedError' ]
      at HTMLElement.<anonymous> (/Users/electron/workspace/electron-mas-x64/spec/webview-spec.js:981:16)
      at WebViewImpl.dispatchEvent (/Users/electron/workspace/electron-mas-x64/out/D/Electron.app/Contents/Resources/electron.asar/renderer/web-view/web-view.js:175:22)
      at EventEmitter.<anonymous> (/Users/electron/workspace/electron-mas-x64/out/D/Electron.app/Contents/Resources/electron.asar/renderer/web-view/guest-view-internal.js:79:15)
      at emitThree (events.js:116:13)
      at EventEmitter.emit (events.js:197:7)

@deepak1556 , maybe you can take a look? I'm absolutely not familiar with media-stuff.

@gerhardberger win builds fail again =(
http://208.52.191.140:8080/job/electron-win-x64/3527/console

@gerhardberger
I have disabled OSR to run tests on Win. Please enable OSR back if/when you push any changes to fix compilation errors. Thanks!

TODO Win builds failed:

[1319/1319] LINK_EMBED electron.exe
FAILED: C:\Python27\python.exe gyp-win-tool link-with-manifests environment.x64 True electron.exe "C:\Python27\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:electron.exe @electron.exe.rsp" 1 mt.exe rc.exe "obj\electron.electron.exe.intermediate.manifest" obj\electron.electron.exe.generated.manifest ..\..\atom\browser\resources\win\atom.manifest
LINK : fatal error LNK1104: cannot open file 'C:/e/workspace/electron-win-x64/vendor/download/libchromiumcontent/shared_library/fx_freetype.lib'

I just wanted you guys to know, that I appreciate your hard work and I believe in you! ❤️

@alexeykuzmin It seems the OSR-related errors resolved, only that last linking error is present.

It seems the OSR-related errors resolved, only that last linking error is present.

@gerhardberger That's great, thanks!
I'll look at Windows build tomorrow. For some reason it works on my machine while it obviously shouldn't.

@kevinsawicki
http://208.52.191.140:8080/job/electron-osx-x64/4561/console :

IOError: [Errno 28] No space left on device

Can we do something to prevent it from happening in the future? It's kind of inconvenient )

Can we do something to prevent it from happening in the future? It's kind of inconvenient )

The machine has 500GB of space, the libchromiumcontent-mas build was taking up 400GB of it, with a _bad_scm folder taking up 278GB in it.

Can we do something to prevent it from happening in the future? It's kind of inconvenient )

Added it to the clean option in electron/libchromiumcontent#321

@alexeykuzmin What version of Chromium does electron currently use? I stumbled on this issue #10000 which SEEMS to have been resolved here: https://chromium.googlesource.com/chromium/src/+/b39b8d6fb03d46dff5556e7a5c428ac9302f5579
I'm trying to figure out if this PR will resolve the issue.

THANKS!

@johnryan
The latest stable Electron v1.6.11 is based on Chromium 56, v1.7.4 (beta) – on Chromium 58.
The changes you are referring to have gotten into 59th release and will be part of Electron 1.8.*.

@alexeykuzmin Awesome, thanks for the info...this is likely out of the scope of this PR, but do you know any timelines for that? Just trying to figure out how to deal with this issue with our users (or figure out a workaround). If that's not your area of expertise no worries, i'll keep digging elsewhere. Thanks again!

Do you guys have any idea when you'll cut a 1.8 release? 😃

@setpixel there are two failing Windows tests that need to be fixed before 1.8 is released. Once we are clear on those issues we will do a 1.8 release. We are tentatively planning on doing a release on Tuesday (August 22nd).

BTW those issues are #10279 and #10280.

I am just curious that integration to foo version of libchroium cannot be fully automated with some CI?

@stanleyxu2005 no, it can't be automated.