Would it make sense to create a feature branch in the electron/electron repo, push all the changes there and re-create a pr?

Would it make sense to create a feature branch in the electron/electron repo, push all the changes there and re-create a pr?

It is not needed on Electron's side, the third party CI workers can work fine.

A thing to notice is that the CI servers normally only build Debug versions, so it is necessary to manually test the Release build. I usually test by running ./script/bump-version.py and then push the changes to a temporary brach, it would trigger CI servers to build Release versions.

PR currently should be in a state with OSR disabled, compilation passing on mac and 18 tests failing.
We're working on win build and looking into tests.

@kevinsawicki @zcbenz
Is there anyone who can look at OSR related compilation errors?
I have disabled OSR for now, at least compilation-wise, but is has to be fixed before a new Electron version can be released.

I might be able to take a look at the OSR code on Windows this week.

I'm going to tidy things up a little bit here and make a force push.
If someone is working on the tests or anything else right now please let me now or simply just push all what you have. I expect to finish everything on June 30th at 9pm UTC (~in three hours).

/cc @tonyganch @kevinsawicki

I'm going to tidy things up a little bit here and make a force push.

Sounds good, I pushed up a commit to fix the failing devtools specs.

On my Windows machine Electron builds successfully but crashes when started.
Can anyone look into it please?

views::LayoutProvider::Get(...) returned nullptr.

/cc @zcbenz @kevinsawicki @tonyganch

Can anyone look into it please?

Yup, taking a look now.

On my Windows machine Electron builds successfully but crashes when started.

I added a default layout provider to fix the crash which was introduced in https://chromium.googlesource.com/chromium/src/+/4e8cac4101f13be9f86b455f06ec7b46fc707e93

Now it launches for me without crashing but the menus don't appear when clicked, investigating further.

Now it launches for me without crashing but the menus don't appear when clicked, investigating further

Fixed this issue, menus now appear on Windows.

Looks like the async menu support was removed in Chrome 59 https://chromium.googlesource.com/chromium/src/+/b31c887a2d14761b078f329629f1d3469106b891%5E%21/ so the stack-allocated MenuDelegate was getting deleted too soon since RunMenu no returns immediately.

I might be able to take a look at the OSR code on Windows this week.

@brenca Is there a chance you would have time to do that anytime soon?

@alexeykuzmin Sorry, I sadly can't. Maybe @gerhardberger could.

@alexeykuzmin @brenca I will try and fix the OSR errors during the week, but I can only test on macOS though.

What is the plan for this PR? When ready, will it be merged to 1.7.x?
Or will you soon "release" 1.7.x and then this is a candidate for 1.8?

AFAIK minor versions are bumped with Chromium and node version bumps, so it would be 1.8.x

@alexeykuzmin can you re-open this pull request from a branch within this repository (instead of your fork) so we can get the CI builds going? They only trigger for branches inside this repository.

@alexeykuzmin can you re-open this pull request from a branch within this repository (instead of your fork) so we can get the CI builds going? They only trigger for branches inside this repository.

@kevinsawicki, sure. The only reason why I left the branch in my fork was this reply by @zcbenz:

Would it make sense to create a feature branch in the electron/electron repo, push all the changes there and re-create a pr?

It is not needed on Electron's side, the third party CI workers can work fine.

@alexeykuzmin can you re-open this pull request from a branch within this repository

@kevinsawicki #9946