Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command#7952
Merged
kevinsawicki merged 7 commits intoelectron:masterfrom Nov 28, 2016
Merged
Conversation
Contributor
|
Thanks for this, would you mind adding a simple spec to Something like but with valid values for all the supported keys: it('supports setting the app details', function () {
assert.doesNotThrow(function () {
window.setAppDetails({appId: 'my.app.id', relaunchCommand: 'electron'})
window.setAppDetails({})
})
})Also, can you update the docs in |
77120de to
a23539c
Compare
3713b49 to
ca4c472
Compare
ca4c472 to
b305020
Compare
Contributor
Author
|
Thanks for the suggestions. I've updated those files. |
76da65d to
3897a88
Compare
Contributor
|
Thanks for adding this, apologies for the delay getting it merged 🚢 👍 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls ui::win::SetAppDetailsForWindow in Chromium.
For microsoft/vscode#13905