Skip to content

Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command#7952

Merged
kevinsawicki merged 7 commits intoelectron:masterfrom
the-ress:window-setappid
Nov 28, 2016
Merged

Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command#7952
kevinsawicki merged 7 commits intoelectron:masterfrom
the-ress:window-setappid

Conversation

@the-ress
Copy link
Contributor

@the-ress the-ress commented Nov 12, 2016

@kevinsawicki
Copy link
Contributor

Thanks for this, would you mind adding a simple spec to spec/api-browser-window-spec.js for this that just verifies it does not crash or throw unexpected errors?

Something like but with valid values for all the supported keys:

it('supports setting the app details', function () {
  assert.doesNotThrow(function () {
    window.setAppDetails({appId: 'my.app.id', relaunchCommand: 'electron'})
    window.setAppDetails({})
  })
})

Also, can you update the docs in docs/browser-window.md with the usage details?

@the-ress the-ress changed the title Added BrowserWindow.setAppId to set user model id, icon and relaunch command Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command Nov 18, 2016
@the-ress the-ress force-pushed the window-setappid branch 3 times, most recently from 3713b49 to ca4c472 Compare November 18, 2016 20:42
@the-ress
Copy link
Contributor Author

Thanks for the suggestions. I've updated those files.

@kevinsawicki kevinsawicki self-assigned this Nov 23, 2016
@kevinsawicki
Copy link
Contributor

Thanks for adding this, apologies for the delay getting it merged 🚢 👍

@kevinsawicki kevinsawicki merged commit a739511 into electron:master Nov 28, 2016
@the-ress
Copy link
Contributor Author

Thanks!

@the-ress the-ress deleted the window-setappid branch November 28, 2016 22:55
@dbradleyfl
Copy link

Heads up: this doesn't seem to do anything anymore #16087 @the-ress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants