I started to write some tests for this, but ran into problems. I started with images, and found that no error is emitted when images are disabled (loading fails silently).

Let me know what we want to do about that.

Adding attribute for every property in webPreferences makes the code hard to maintain, I think we should probably add a generic attribute to set webPreferences like the features string of window.open instead, or add the events as described in #2749 (comment).

Ok. I'll submit a new PR with a webpreferences string

On Oct 3, 2016, at 7:28 AM, Cheng Zhao [email protected] wrote:

Adding attribute for every property in webPreferences makes the code hard to maintain, I think we should probably add a generic attribute to set webPreferences like the features string of window.open instead, or add the events as described in #2749 (comment).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing. This PR is replace by #7631.