Maintain stack of visited objects for cycle detection #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
circular-references
branch
from
e0d3bd3 to
bd58e1b
Compare
kevinsawicki
force-pushed
the
circular-references
branch
from
fe90ff3 to
00f82aa
Compare
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
visitedobjects array grew for all arguments which would mean circular references could be detected for arrays and objects referenced multiple times but not actually referencing each other in a circular fashion.Now values are removed from the
visitedset once they are fully serialized and stillnull-ed out when a cycle is detected.Closes #6435