fix: close the utilityProcess port before its descriptor is destroyed by claude[bot] · Pull Request #55274 · electron/electron

claude · 2026-10-23T16:57:45Z

Description of Change

Manually backport #55233. See that PR for details.

Conflict note: this branch's UtilityProcessWrapper does not observe BrowserChildProcessObserver, so the destructor only gains the CloseConnectorPort()/CloseStdioReadFds() calls and the rest of the change (constructor-time registry, base::Unretained error handler, ShutdownAll() from PostMainMessageLoopRun()) applies as on main.

Checklist

I have built and tested this change
I have filled out the PR description
I have reviewed and verified the changes
npm test passes
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LPMvJBQiyP6b7QjatACmnS

Release Notes

Notes: Fixed utilityProcess not emitting an exit event when the app quit while the process was still launching.

Manual backport of #55233. 45-x-y has no BrowserChildProcessObserver in UtilityProcessWrapper, so the destructor only gains the CloseConnectorPort()/CloseStdioReadFds() calls and the rest applies as is. (cherry picked from commit 4508468) Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01LPMvJBQiyP6b7QjatACmnS

claude

I reviewed this backport from a standalone clone and found no bugs. It changes how utilityProcess wrappers are torn down, including what their destructors do during GC, and the checklist says it has not been built or tested yet, so a human look would still be worthwhile.

What was reviewed:

The registry now stores weak handles and registers each wrapper in its constructor. I checked both ways a wrapper leaves it: HandleTermination() removes it by pointer and sweeps out null entries, and the posted fail_launch termination goes through that same function.
ShutdownAll() copies the live wrappers into strong handles before calling Shutdown(), so removing wrappers from the registry while it loops cannot invalidate the loop.
The base::Unretained error handler is only safe because the wrapper owns connector_ and only ever resets it. The new destructor calls only touch native members. I couldn't confirm the upstream claims (what GiveDisentangledHandle does when given an invalid handle, and the DCHECK in MessagePortDescriptor::Reset) because that code isn't in this checkout.

Extended reasoning...

The change touches utilityProcess lifetime in shell/browser/api/electron_api_utility_process.cc and .h, plus the browser shutdown path in electron_browser_main_parts.cc. It touches no security-sensitive surface such as renderer IPC validation, permissions or webPreferences. The registry now tracks wrappers that have not launched yet, the connector error handler is now bound with a raw pointer, and the destructor now runs cleanup during GC sweeping. Whether that is correct depends on Chromium and cppgc behavior that this standalone clone cannot show. The PR checklist says the change has not been built or tested, which is why this defers rather than approves.

claude · 2026-10-23T18:22:21Z

macos-arm64 / test / test (darwin, 1) (job 120559746177) did not report a test failure: its only annotation is "The hosted runner lost communication with the server", alongside GitHub's notice about macOS arm64 runner capacity constraints. The runner dropped about 46 minutes in, so no test log or Datadog results were uploaded. The same shard passed on this PR's 43-x-y sibling (#55272) and on every recent 45-x-y Build run (39960837258, 39884729026, 39868431395, 39856150219, 39813481178), so I'm treating it as a runner loss rather than this change. I'll re-run the failed job once the workflow run finishes.

Generated by Claude Code

release-clerk · 2026-10-23T20:32:50Z

Release Notes Persisted

Fixed utilityProcess not emitting an exit event when the app quit while the process was still launching.

##### [v44.10.1](https://github.com/electron/electron/releases/tag/v44.10.1) ### Release Notes for v44.10.1 #### Fixes - Fixed DevTools "Save" prompting for a location every time instead of reusing the previously chosen file. [#55484](electron/electron#55484) - Fixed DevTools "Save As" using the old file and Linux cancels treated as saved. - Fixed `webContents.adjustSelection()` ignoring the `end` option. [#55461](electron/electron#55461) (Also in [45](electron/electron#55462), [46](https://github.com/electron/electron/pull/55463)) #### Performance Improvements - Improved performance of `net.fetch()` requests without a body. [#55445](electron/electron#55445) (Also in [43](electron/electron#55447), [45](electron/electron#55446), [46](https://github.com/electron/electron/pull/55444)) - Improved performance of repeated `net.fetch()` calls for `file:` URLs. [#55458](electron/electron#55458) (Also in [45](electron/electron#55459), [46](https://github.com/electron/electron/pull/55457)) #### Other Changes - Backported fixes from upstream Chromium, Dawn, Skia and V8. [#55492](electron/electron#55492) ##### [v44.10.0](https://github.com/electron/electron/releases/tag/v44.10.0) ### Release Notes for v44.10.0 #### Features - Added filtering options to `session.registerPreloadScript` - `matches`, `excludeMatches`, `includeGlobs`, `excludeGlobs`, `matchOriginAsFallback`. [#55182](electron/electron#55182) (Also in [45](https://github.com/electron/electron/pull/55181)) #### Fixes - Fixed a crash on Linux when a D-Bus method call was made on a disconnected bus. [#55290](electron/electron#55290) (Also in [45](electron/electron#55292), [46](https://github.com/electron/electron/pull/55289)) - Fixed a main process crash when `onSendHeaders` observed Blob uploads. [#55168](electron/electron#55168) (Also in [45](https://github.com/electron/electron/pull/55169)) - Fixed `app.getLoginItemSettings()` not finding login items on Windows when the executable path contains spaces. [#55207](electron/electron#55207) (Also in [45](https://github.com/electron/electron/pull/54419)) - Fixed Europe/London and Europe/Dublin time zone names showing as "GMT+00:00" in winter by updating ICU to tzdata 2026e. [#55335](electron/electron#55335) - Fixed File System Access blocklist gaps for `.git/hooks` writes and hypervisor UNC shares. [#55330](electron/electron#55330) - Fixed handling of malformed asar archives whose size fields do not match the file length. [#55176](electron/electron#55176) (Also in [43](electron/electron#55179), [45](https://github.com/electron/electron/pull/55175)) - Fixed inconsistent handling of asar archive paths between the main process and child processes. [#55183](electron/electron#55183) (Also in [43](electron/electron#55185), [45](https://github.com/electron/electron/pull/55184)) - Fixed `Menu.popup()` on macOS sometimes not showing a menu after another closed. [#55325](electron/electron#55325) (Also in [45](electron/electron#55326), [46](https://github.com/electron/electron/pull/55324)) - Fixed MV3 extension events not arriving to background service workers. [#55152](electron/electron#55152) (Also in [43](electron/electron#55153), [45](https://github.com/electron/electron/pull/55154)) - Fixed paste hanging indefinitely on Linux X11 until the app was restarted. [#55327](electron/electron#55327) - Fixed `protocol.registerSource` schemes not applying the same fetch rules as `protocol.handle` schemes. [#55177](electron/electron#55177) (Also in [45](https://github.com/electron/electron/pull/55178)) - Fixed `utilityProcess` not emitting an `exit` event when the app quit while the process was still launching. [#55273](electron/electron#55273) (Also in [43](electron/electron#55272), [45](electron/electron#55274), [46](https://github.com/electron/electron/pull/55264)) #### Other Changes - Updated Chromium to 152.0.7977.169. [#55033](electron/electron#55033) - Updated Node.js to v24.22.1. [#55162](electron/electron#55162) ##### [v44.9.3](https://github.com/electron/electron/releases/tag/v44.9.3) ### Release Notes for v44.9.3 #### Other Changes - Backported fixes from upstream ANGLE, Chromium, PDFium, Skia and V8. [#55149](electron/electron#55149) ##### [v44.9.2](https://github.com/electron/electron/releases/tag/v44.9.2) ### Release Notes for v44.9.2 ##### [v44.9.1](https://github.com/electron/electron/releases/tag/v44.9.1) ### Release Notes for v44.9.1 > \[!NOTE] > This release contains the fix for <GHSA-jr5w-w6x2-84p9>, the mitigation for compromised eMudhra intermediate certificates ##### [v44.9.0](https://github.com/electron/electron/releases/tag/v44.9.0) ### Release Notes for v44.9.0 #### Features - Added app shims on macOS to show windows under another app's Dock icon. [#55073](electron/electron#55073) (Also in [45](https://github.com/electron/electron/pull/55072)) #### Fixes - Fixed link-opened windows not using the opener's session and `webPreferences`. [#55048](electron/electron#55048) (Also in [42](electron/electron#55050), [43](electron/electron#55049), [45](https://github.com/electron/electron/pull/55051)) - Fixed `setCertificateVerifyProc` occasionally not being applied to a request issued concurrently with the first request to a host. [#55046](electron/electron#55046) (Also in [42](electron/electron#55054), [43](electron/electron#55047), [45](https://github.com/electron/electron/pull/55045)) ##### [v44.8.0](https://github.com/electron/electron/releases/tag/v44.8.0) ### Release Notes for v44.8.0 #### Features - Added support for `Notification` action buttons on Linux. [#54890](electron/electron#54890) (Also in [45](https://github.com/electron/electron/pull/54889)) #### Fixes - Fixed mouse cursor missing over native dialogs in certain scenarios on Windows. [#54987](electron/electron#54987) - Fixed `net.fetch` and `session.fetch` failing permanently with `net::ERR_FAILED` after the Network Service process restarts. [#54909](electron/electron#54909) (Also in [42](electron/electron#54925), [43](electron/electron#54908), [45](https://github.com/electron/electron/pull/54910)) - Fixed `utilityProcess` dropping messages posted with `process.parentPort.postMessage()` right before the process exits. [#54960](electron/electron#54960) (Also in [42](electron/electron#55000), [43](electron/electron#54962), [45](https://github.com/electron/electron/pull/54956)) - Fixed `win.isFullScreen()` being stale in fullscreen events on Windows. [#55009](electron/electron#55009) (Also in [45](https://github.com/electron/electron/pull/55008)) #### Other Changes - Backported fixes from upstream Chromium and V8. [#55034](electron/electron#55034) - Updated Chromium to 152.0.7977.167. [#54928](electron/electron#54928) - Updated Node.js to v24.22.0. [#55004](electron/electron#55004) ##### [v44.7.2](https://github.com/electron/electron/releases/tag/v44.7.2) ### Release Notes for v44.7.2 #### Fixes - Fixed an issue where clicks posted to a background app were dropped on macOS. [#54819](electron/electron#54819) (Also in [45](https://github.com/electron/electron/pull/54818)) - Fixed interrupted macOS updates leaving a broken app behind. [#54844](electron/electron#54844) (Also in [45](https://github.com/electron/electron/pull/54843)) #### Other Changes - Backported fixes from upstream ANGLE, Chromium, PDFium and V8. [#54898](electron/electron#54898) #### Documentation - Documentation changes: [#54880](electron/electron#54880) ##### [v44.7.1](https://github.com/electron/electron/releases/tag/v44.7.1) ### Release Notes for v44.7.1 #### Fixes - Fixed a crash when starting without an available display server on Linux. [#54794](electron/electron#54794) (Also in [45](https://github.com/electron/electron/pull/54781)) - Fixed a Linux crash creating a window with a menu bar when GTK failed to load. [#54859](electron/electron#54859) (Also in [45](https://github.com/electron/electron/pull/54846)) - Fixed a `WebContentsView` that was removed with `removeChildView()` and re-added with `addChildView()` staying hidden behind its sibling views on Linux. [#54798](electron/electron#54798) - Fixed asar archives in non-ASCII folders failing to load on Linux. [#54849](electron/electron#54849) (Also in [45](https://github.com/electron/electron/pull/54848)) - Fixed renderer crashes during garbage collection inside ShadowRealms. [#54865](electron/electron#54865) (Also in [45](https://github.com/electron/electron/pull/54864)) #### Other Changes - Refactored mouse forwarding on Windows to fix `setIgnoreMouseEvents(true, { forward: true })` related issues. [#54802](electron/electron#54802) (Also in [45](https://github.com/electron/electron/pull/54803)) - Updated Chromium to 152.0.7977.149. [#54085](electron/electron#54085) ##### [v44.7.0](https://github.com/electron/electron/releases/tag/v44.7.0) ### Release Notes for v44.7.0 #### Features - The macOS `autoUpdater` now streams update downloads to disk, resumes an interrupted download on the next check instead of starting over, and applies a binary delta when the update feed offers one for the running version. [#54204](electron/electron#54204) #### Fixes - Fixed an uncatchable TypeError in `net.fetch` when receiving response headers with non-ASCII characters, and preserved multiple Set-Cookie headers. [#54672](electron/electron#54672) #### Other Changes - Backported fixes from upstream ANGLE, Chromium, Dawn, fontconfig, Skia, V8 and WebRTC. [#54666](electron/electron#54666) - Backported fixes from upstream ANGLE, Chromium, Skia, V8 and WebRTC. [#54657](electron/electron#54657) ##### [v44.6.0](https://github.com/electron/electron/releases/tag/v44.6.0) ### Release Notes for v44.6.0 #### Features - Added the experimental `protocol.registerSource()` to serve a custom scheme from directories on disk without a JavaScript handler. [#54522](electron/electron#54522) (Also in [45](https://github.com/electron/electron/pull/54521)) #### Fixes - Fixed a crash on launch on macOS when the system refused to register the app for sleep/wake notifications. [#54596](electron/electron#54596) - Fixed a crash on `navigator.usb.requestDevice()` in in-memory sessions. [#54616](electron/electron#54616) (Also in [45](https://github.com/electron/electron/pull/54615)) - Fixed `webview.findInPage()` hanging when the host page also has an iframe. [#54586](electron/electron#54586) (Also in [43](electron/electron#54584), [45](https://github.com/electron/electron/pull/54585)) - Updated time zone data to tzdata 2026d, including British Columbia's move to permanent UTC-7. [#54623](electron/electron#54623) #### Documentation - Documentation changes: [#54589](electron/electron#54589)

trop Bot mentioned this pull request Oct 23, 2026

fix: close the utilityProcess port before its descriptor is destroyed #55233

Merged

1 of 4 tasks

trop Bot requested review from deepak1556 and jkleinsc October 23, 2026 16:58

trop Bot added 45-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 23, 2026

claude Bot assigned jkleinsc Oct 23, 2026

claude Bot commented Oct 23, 2026

View reviewed changes

MarshallOfSound approved these changes Oct 23, 2026

View reviewed changes

MarshallOfSound enabled auto-merge (squash) October 23, 2026 20:30

ckerr approved these changes Oct 23, 2026

View reviewed changes

MarshallOfSound merged commit 0b6c60b into 45-x-y Oct 23, 2026
140 of 142 checks passed

MarshallOfSound deleted the manual-bp/claude/pr/55233/branch/45-x-y branch October 23, 2026 20:32

electron-release-board Bot added this to 45-x-y Oct 23, 2026

Navigation Menu

Repository navigation

fix: close the utilityProcess port before its descriptor is destroyed - #55274

fix: close the utilityProcess port before its descriptor is destroyed#55274
MarshallOfSound merged 1 commit into
45-x-yfrom
manual-bp/claude/pr/55233/branch/45-x-y

claude Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

claude Bot commented Oct 23, 2026

Uh oh!

Uh oh!

release-clerk Bot commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

claude Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Oct 23, 2026

Uh oh!

Uh oh!

release-clerk Bot commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

claude Bot commented Oct 23, 2026 •

edited

Loading