Repository navigation
test: wait for the parent's ack before utility children exit - #55122
Merged
MarshallOfSound merged 1 commit intoOct 20, 2026
Conversation
process.exit() does not wait for pending postMessage() writes, so a utility child that exits right after posting can lose its message. Restore the acknowledgement handshake that #54924 removed from the api-net fixture and helper, and add it to the env-app and js2c-code-cache fixtures, so those children only exit once the parent has acknowledged their message. The #54924 test no longer posts right before exiting. The child posts its parentPort messages, then posts on a transferred MessagePortMain and exits only when the parent replies there. parentPort and the port share the same ordered Mojo channel, so all of the parentPort messages have reached the parent when the port message does. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01LPMvJBQiyP6b7QjatACmnS Co-authored-by: Claude <[email protected]>
MarshallOfSound
approved these changes
Oct 20, 2026
MarshallOfSound
deleted the
trop/43-x-y-bp-test-wait-for-the-parent-s-ack-before-utility-children-exit-1792455098765
branch
October 20, 2026 07:50
|
No Release Notes |
shariqh
added a commit
to shariqh/agent-inbox
that referenced
this pull request
Oct 24, 2026
Electron 43.8.3 keeps 43.8.1's fix for GHSA-jr5w-w6x2-84p9 (the compromised eMudhra intermediate certificates) and adds electron/electron#55147: 64 cherry-picks from upstream ANGLE, Chromium, PDFium, Skia and V8, including use-after-free fixes and "[net] Validate server certificate before generating auth token". 43.8.2 changed only a test (electron/electron#55122). 43.8.3 still embeds Node 24.22.0 and stays on NODE_MODULE_VERSION 148. Move every pin from 43.8.1 to 43.8.3: - package.json devDependency and allowScripts entry, package-lock.json (regenerated with npm install --save-exact [email protected]); - release/linux-inputs.json, release/macos-inputs.json and release/windows-inputs.json electron.version, and PINNED_ELECTRON_VERSION in scripts/windows-release-inputs.mjs; - the linux-inputs.json SHA-256 pinned by the AppImage (x64/arm64) and DEB contracts and their tests; - the tests that compare against the real pins, and the release docs. All 75 entries of the electron package's checksums.json match the official v43.8.3 SHASUMS256.txt. That is a bump-time cross-check: packager() gets no download options, so the build checks each zip only against the release's live SHASUMS256.txt (#363 will pin it to checksums.json). Electron carried the #53393 patches only in 43.6.0 to 43.7.11. From 43.8.0, 43.8.3 included, the #135 fix comes from Node 24.22.0 itself. The abort diagnosis in scripts/electron-sqlite-check.mjs now says so, and its test checks the wording. Co-authored-by: Copilot <[email protected]> Copilot-Session: 9e7ec7a7-8690-49e5-9d55-492fedc3027a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #55082
See that PR for details.
Notes: none