Repository navigation
test: re-enable Node.js tests that now pass with BoringSSL - #55094
Merged
Merged
Conversation
Most of these were disabled because BoringSSL behaved differently from OpenSSL. Upstream Node.js made the tests BoringSSL-aware in nodejs/node#63161 (v24.18.0) and fixed the ML-KEM expectations in nodejs/node#65966 (v24.22.0), so they now pass. The es-module/test-esm-wasm entry is a stale prefix: test.py matches entries as substrings of the path, so it was hiding 13 split files that pass. A few entries are dropped because the tests now skip themselves. 43-x-y has no Node.js flaky-test list, so parallel/test-cluster-primary-error, parallel/test-cluster-primary-kill and parallel/test-worker-resource-limits stay disabled here. (cherry picked from commit bcc5c51) Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M
3 of 4 tasks
dsanders11
approved these changes
Oct 19, 2026
jkleinsc
approved these changes
Oct 19, 2026
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by David Babenko-Sanders · Slack thread
Description of Change
Manually backport #55071. See that PR for details.
43-x-y has no Node.js flaky-test list, so
parallel/test-cluster-primary-error,parallel/test-cluster-primary-killandparallel/test-worker-resource-limitsstay disabled here instead of moving to it; the other 72 entries removed by #55071 are removed here, and branch-only entries are kept. Validated locally by running the 124 test files covered by the removed entries against the Electron v43.8.0 linux-x64 release with the 43-x-y Node.js patches applied to v24.22.0 (3 runs, all passed; 33 skip themselves under BoringSSL).Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M
Generated by Claude Code
Release Notes
Notes: none