Repository navigation
fix: avoid menu bar crash when GTK cannot initialize - #54777
Merged
Merged
Conversation
ckerr
added
semver/patch
Guard GTK menu color lookups on toolkit theme availability and fall back to Views menu colors when GTK initialization fails. Cover framed window creation and theme refresh with an incompatible Wayland GSettings schema. Fixes #54594 Co-authored-by: Copilot <[email protected]>
Add gtk_util::IsGtkAvailable() and use it for the menu bar's GTK color lookup. Also use it in the icon lookup behind app.getApplicationInfoForProtocol(), which called into GTK the same way and crashed when GTK was not loaded. Run api-menu.spec.ts on the Wayland CI leg so the new spec runs in CI, and describe the fallback menu colors accurately in the docs. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ckerr
force-pushed
the
fix/wayland-menu-gtk-fallback
branch
from
October 9, 2026 03:31
d23443a to
4b557d6
Compare
In CI there is no accessibility D-Bus service and no accessibility env var, so Chromium's accessibility check falls back to reading toolkit-accessibility from org.gnome.desktop.interface. The spec's minimal schema lacked that key, so GLib aborted the app with SIGTRAP. Real schemas that predate font-antialiasing still have toolkit-accessibility. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jkleinsc
approved these changes
Oct 12, 2026
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "44-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "43-x-y" cleanly; |
trop
Bot
added
needs-manual-bp/44-x-y
needs-manual-bp/43-x-y
and removed
target/44-x-y
Contributor
|
I have automatically backported this PR to "45-x-y", please check out #54846 |
trop
Bot
added
in-flight/45-x-y
merged/45-x-y
5 of 7 tasks
Contributor
|
claude[bot] has manually backported this PR to "44-x-y", please check out #54859 |
dsanders11
pushed a commit
that referenced
this pull request
Oct 13, 2026
fix: avoid menu bar crash when GTK cannot initialize (#54777) * fix: avoid menu bar crash when GTK cannot initialize Guard GTK menu color lookups on toolkit theme availability and fall back to Views menu colors when GTK initialization fails. Cover framed window creation and theme refresh with an incompatible Wayland GSettings schema. Fixes #54594 * fix: check GTK availability with one helper Add gtk_util::IsGtkAvailable() and use it for the menu bar's GTK color lookup. Also use it in the icon lookup behind app.getApplicationInfoForProtocol(), which called into GTK the same way and crashed when GTK was not loaded. Run api-menu.spec.ts on the Wayland CI leg so the new spec runs in CI, and describe the fallback menu colors accurately in the docs. * test: give the no-GTK menu spec's schema the toolkit-accessibility key In CI there is no accessibility D-Bus service and no accessibility env var, so Chromium's accessibility check falls back to reading toolkit-accessibility from org.gnome.desktop.interface. The spec's minimal schema lacked that key, so GLib aborted the app with SIGTRAP. Real schemas that predate font-antialiasing still have toolkit-accessibility. --------- (cherry picked from commit 9cb9173) Claude-Session: https://claude.ai/code/session_015GReMcdLqJ1Grhw5C8TvVx Co-authored-by: Claude <[email protected]>
trop
Bot
added
merged/44-x-y
5 of 7 tasks
Contributor
|
claude[bot] has manually backported this PR to "43-x-y", please check out #54884 |
claude Bot
pushed a commit
that referenced
this pull request
Oct 13, 2026
Manual backport of #54777 to 43-x-y. Conflicts: - shell/browser/ui/gtk_util.cc: 43-x-y also includes SkUnPreMultiply.h; kept it and added the new ui/color and ui/linux includes after it. - script/wayland-test-allowlist.txt: 43-x-y's allowlist has no api-clipboard.spec.ts entry; added only api-menu.spec.ts. (cherry picked from commit 9cb9173) Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Cn8pbCoCtwodWGX6aQ94o4
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 14, 2026
fix: avoid menu bar crash when GTK cannot initialize (#54777) Manual backport of #54777 to 43-x-y. Conflicts: - shell/browser/ui/gtk_util.cc: 43-x-y also includes SkUnPreMultiply.h; kept it and added the new ui/color and ui/linux includes after it. - script/wayland-test-allowlist.txt: 43-x-y's allowlist has no api-clipboard.spec.ts entry; added only api-menu.spec.ts. (cherry picked from commit 9cb9173) Claude-Session: https://claude.ai/code/session_01Cn8pbCoCtwodWGX6aQ94o4 Co-authored-by: Claude <[email protected]>
trop
Bot
added
merged/43-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #54594
On Linux,
MenuBar::RefreshColorCache()always read the menu bar colors from GTK.When GTK cannot initialize, for example on GNOME 3.32 under Wayland, whose
org.gnome.desktop.interfaceschema lacks keys Chromium requires, GTK is never loaded.The
gtk::helpers then call through null function pointers, so creating a framedBrowserWindowwith a menu crashed.#54365 fixed the same problem in the title bar; this fixes the menu bar.
gtk_util::IsGtkAvailable(), which is true only when Chromium's GTK UI initialized.nativeTheme.app.getApplicationInfoForProtocol()called into GTK the same way. It now returns no icon instead of crashing, so the promise rejects with the existing "Failed to get file icon." error.api-menu.spec.tsto the Wayland CI allowlist so that spec runs in CI.Validation
Ran on a local Linux testing build of
mainunder headless weston, the same way as CI's Wayland leg:api-menu.spec.tspassed (128 passed; the rest skipped by their own platform conditions).🤖 Generated with Claude Code
Checklist
npm testpassesRelease Notes
Notes: Fixed a Linux crash creating a window with a menu bar when GTK failed to load.