Repository navigation
feat: support Notification action buttons on Linux - #54516
Merged
Merged
Conversation
MarshallOfSound
approved these changes
Oct 13, 2026
VerteDinde
approved these changes
Oct 13, 2026
|
Release Notes Persisted
|
This was referenced Oct 13, 2026
Contributor
|
I have automatically backported this PR to "45-x-y", please check out #54889 |
Contributor
|
I have automatically backported this PR to "44-x-y", please check out #54890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Notification'sactionsoption andactionevent were macOS and Windows only. On Linux the buttons were dropped without an error, even though libnotify and most desktop notification servers support them.Each
buttonentry inactionsis now added to the notification when the server advertises theactionscapability. Pressing one emitsactionwith that entry's index and aselectionIndexof-1, as on macOS. Buttons go through the same callback as the default click, so the activation token is picked up first and an app can focus a window from the handler on Wayland.selectionentries and buttons withouttextare skipped.Tested against the fake notification daemon in
spec/api-notification-dbus.spec.ts, and on GNOME Shell 50.4 (Wayland): the buttons render, pressing one emitsactionwith the right index followed byclose, and focusing a window from the handler raises it over another app's window.Checklist
Release Notes
Notes: Added support for
Notificationaction buttons on Linux.